Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #172 add table showing installation of app for developer #186

Merged
merged 5 commits into from
Feb 6, 2020
Merged

feat: #172 add table showing installation of app for developer #186

merged 5 commits into from
Feb 6, 2020

Conversation

vuhuucuong
Copy link
Contributor

Fixes: #172

@github-actions github-actions bot added the marketplace Relates to the Marketplace label Feb 5, 2020
willmcvay
willmcvay requested changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just a few code hints on the sort functions would be nice 👍

packages/marketplace/src/components/pages/analytics.tsx Outdated Show resolved Hide resolved
packages/marketplace/src/components/pages/analytics.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from willmcvay February 6, 2020 02:18
@github-actions github-actions bot requested a review from duong-se February 6, 2020 03:25
@vuhuucuong
Copy link
Contributor Author

vuhuucuong commented Feb 6, 2020 •
edited
Loading

I fixed all. Pls help me to review again

duong-se
duong-se approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se changed the title feat/172 add table showing installation of app for developer feat: #172 add table showing installation of app for developer Feb 6, 2020
willmcvay
willmcvay approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better 👍

@vuhuucuong vuhuucuong merged commit 119b2f9 into master Feb 6, 2020
@vuhuucuong vuhuucuong deleted the feat/172-add-table-showing-installation-of-app-for-developer branch February 6, 2020 06:44
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@zlatanpham
[CLD-410] update feature app banner (#186)
65153d3
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@vuhuucuong
feat: #172 add table showing installation of app for developer (#186)
f7a1539 
* feat: #172 Add table showing installation of app for developer page

* feat: #172 Remove import css

* feat: #172 add some comment and type hints

* feat: #172 remove unnecessary deps

* feat: #172 separate functions for readable
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duong-se duong-se duong-se approved these changes

@willmcvay willmcvay willmcvay approved these changes

@dannd4 dannd4 Awaiting requested review from dannd4

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@zlatanpham zlatanpham Awaiting requested review from zlatanpham

Assignees

@vuhuucuong vuhuucuong

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a ‘Developer’, I want to see a table showing installations for each of my apps
3 participants
@vuhuucuong @willmcvay @duong-se