Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #102 - purge unused bulma styles from mono repo prod styles #175

Merged
merged 4 commits into from
Feb 6, 2020
Merged

Fix: #102 - purge unused bulma styles from mono repo prod styles #175

merged 4 commits into from
Feb 6, 2020

Conversation

phmngocnghia
Copy link
Contributor

@phmngocnghia phmngocnghia commented Feb 3, 2020 •
edited
Loading

fixes #102

flows

  1. glob the tsx, ts of src of elements/src
  2. build elements scss-es in a single css
  3. purge it against contents of files in {1}
  4. webpack sass config's entry will be tweaked
  • dev: include elements/src/styles/index.scss
  • the prod script will:
    • execute 1,2,3
    • collect CSS to scripts/webpack/webpack-sass-prod/.temp/index.css
    • Add index.css to the entry of sass prod build script

@github-actions github-actions bot added elements Relates to Elements components and utilities marketplace Relates to the Marketplace labels Feb 3, 2020
@phmngocnghia phmngocnghia force-pushed the fix/102-purge-unused-bulma-styles-from-mono-repo-prod-styles branch 2 times, most recently from 2dc2c4c to 8513ec5 Compare February 4, 2020 03:22
@github-actions github-actions bot added aml-checklist Relates to Anti-money laundering app geo-diary Relates to GEO Diary app lifetime-legal Relates to Lifetime Legal App smb-onboarder Relates to Small Medium Business onboarding app labels Feb 4, 2020
@phmngocnghia phmngocnghia changed the title [WIP] Fix: #102 - purge unused bulma styles from mono repo prod styles Fix: #102 - purge unused bulma styles from mono repo prod styles Feb 4, 2020
willmcvay
willmcvay reviewed Feb 5, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing, looks good though, nice work 👍

packages/elements/purifyOptions.js Outdated
@@ -0,0 +1,30 @@
// Other node scripts will used this file: webpack.sass.prod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File names kebab-case please

duong-se
duong-se approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phmngocnghia phmngocnghia force-pushed the fix/102-purge-unused-bulma-styles-from-mono-repo-prod-styles branch from f48d7b3 to 0cc7e49 Compare February 6, 2020 07:22
willmcvay
willmcvay approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@willmcvay willmcvay force-pushed the fix/102-purge-unused-bulma-styles-from-mono-repo-prod-styles branch from 0cc7e49 to 1e122ae Compare February 6, 2020 10:44
@github-actions github-actions bot requested a review from willmcvay February 6, 2020 10:44
@willmcvay willmcvay merged commit 6ac5114 into master Feb 6, 2020
@willmcvay willmcvay deleted the fix/102-purge-unused-bulma-styles-from-mono-repo-prod-styles branch February 6, 2020 11:08
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@duong-se
Migrate to new credentials (#175)
9b087aa
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@vuhuucuong
Merge pull request #175 from reapit/task/CLD-586-create-helper-component
d3e9915 
[CLD-586] Create Helper component
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
Fix: #102 - purge unused bulma styles from mono repo prod styles (#175)
f107a43 
* poc

* fix: typos

* chore: add comments to scripts

* rename file purifyOptions to purify-options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannd4 dannd4 Awaiting requested review from dannd4

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

@zlatanpham zlatanpham Awaiting requested review from zlatanpham

@duong-se duong-se Awaiting requested review from duong-se

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@phmngocnghia phmngocnghia

Labels
aml-checklist Relates to Anti-money laundering app elements Relates to Elements components and utilities geo-diary Relates to GEO Diary app lifetime-legal Relates to Lifetime Legal App marketplace Relates to the Marketplace smb-onboarder Relates to Small Medium Business onboarding app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS Purge plugin needs fixing for prod builds
3 participants
@phmngocnghia @willmcvay @duong-se