Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added method to download rows as csv #10722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bashleigh
Copy link
Contributor

Pull request checklist

Detail as per issue below (required):

fixes: #10709

Small issue with page size, cannot fetch more than 999 per page. Not sure if there's a query param to increase it or whether I need to paginate the request to get all users for the download.

Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

} catch (error) {
logger(error as Error)
}
setCsvLoading(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a finally for this?

@@ -185,6 +246,11 @@ export const UsersPage: FC = () => {
) : users?._embedded?.length ? (
<>
<BodyText>Total Users: {users?.totalCount}</BodyText>
<ButtonGroup>
<Button intent="primary" loading={csvLoading} disabled={csvLoading} onClick={() => downloadAsCSV()}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just pass downloadAsCSV to the on click right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide CSV on RC Service App
2 participants