Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GQL version to App Scaffolder #228

Closed
phmngocnghia opened this issue Feb 11, 2020 · 3 comments · Fixed by #2556
Closed

Add GQL version to App Scaffolder #228

phmngocnghia opened this issue Feb 11, 2020 · 3 comments · Fixed by #2556
Assignees
Labels
feature New feature or request front-end Relates to front end issues graphql-server react-app-scaffolder Relates to React App Scaffolder package

Comments

@phmngocnghia
Copy link
Contributor

phmngocnghia commented Feb 11, 2020

Create an internal react scaffold version that uses Apollo client to interact with GraphQL Service.

  • Should be an option from CLI
  • Should be based on Non Redux version of internal scaffolder
  • Should also ensure other scaffolds are still working and updated to latest lib versions.
@duong-se duong-se self-assigned this Feb 11, 2020
@duong-se
Copy link
Contributor

as @willmcvay comment i'll move this ticket to Backlog and work after release production
// just comment out question ask do you want to use graphql in CLI

@HollyJoyPhillips HollyJoyPhillips added front-end Relates to front end issues graphql-server labels Feb 19, 2020
@willmcvay willmcvay changed the title Subtask of #33: Update 'GraphQL' option Add GQL version to App Scaffolder Mar 2, 2020
@willmcvay willmcvay added this to the Graph QL Alpha Release milestone Apr 10, 2020
@willmcvay willmcvay added the feature New feature or request label Apr 21, 2020
@willmcvay willmcvay added the react-app-scaffolder Relates to React App Scaffolder package label Jul 21, 2020
@phmngocnghia phmngocnghia self-assigned this Aug 24, 2020
@phmngocnghia phmngocnghia removed their assignment Aug 24, 2020
@vuhuucuong vuhuucuong self-assigned this Aug 31, 2020
vuhuucuong pushed a commit that referenced this issue Sep 1, 2020
vuhuucuong pushed a commit that referenced this issue Sep 3, 2020
vuhuucuong pushed a commit that referenced this issue Sep 3, 2020
vuhuucuong pushed a commit that referenced this issue Sep 3, 2020
vuhuucuong pushed a commit that referenced this issue Sep 3, 2020
@vuhuucuong
Copy link
Contributor

hi @willmcvay & @HollyJoyPhillips . Here're the steps to test this:

  • cd to packages/react-app-scaffolder
  • yarn scaffold
  • Select Apollo GraphQL option and generate an app
  • Fill in the required data in config.json
  • Add the generated's package name in the root package.json like this
    Screen Shot 2020-09-04 at 14 29 03
  • yarn workspace [app-name] start:dev
  • Login and open console to see the data from graphql server

@duong-se
Copy link
Contributor

duong-se commented Sep 7, 2020

Verified, Moving to DONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Relates to front end issues graphql-server react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants