Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our distributed NPM packages should have their dependencies declared #167

Closed
willmcvay opened this issue Feb 3, 2020 · 0 comments
Closed

Our distributed NPM packages should have their dependencies declared #167

willmcvay opened this issue Feb 3, 2020 · 0 comments
Assignees
@trankhacvy
Labels
bug Something isn't working cognitio-auth config-manager Relates to Config Manager package elements Relates to Elements components and utilities front-end Relates to front end issues react-app-scaffolder Relates to React App Scaffolder package ts-definitions Relates to TS Definitions package web-components
Milestone
Foundations Alpha...

Comments

@willmcvay
Copy link
Contributor

  • When migrating to the mono-repo, the dependencies for sub packages were move to the root - this was to help stabilise our dependencies. It had an un-intended effect as now if a user tries to install one of our packages via NPM, they will not get the sub-dependencies installed.
  • Task is for our NPM distributed packages, copy-paste the dependencies required from the main manifest into the package.json of the individual packages. This will have no effect locally but will ensure third parties get the dependencies they need when they run yarn or npm install.
@willmcvay willmcvay added bug Something isn't working cognitio-auth config-manager Relates to Config Manager package elements Relates to Elements components and utilities react-app-scaffolder Relates to React App Scaffolder package ts-definitions Relates to TS Definitions package web-components labels Feb 3, 2020
@trankhacvy trankhacvy self-assigned this Feb 3, 2020
@trankhacvy trankhacvy reopened this Feb 3, 2020
trankhacvy pushed a commit that referenced this issue Feb 5, 2020
@khacvy007
fix: #167 fix npm packages dependencies
08c5c5b
@HollyJoyPhillips HollyJoyPhillips added the front-end Relates to front end issues label Feb 10, 2020
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@vinhnhq
CLD-411|add admin dev management and delete developer feature (#167)
9ee8947 
* CLD-411|add admin dev management and delete developer feature

* CLD-411|update unit test

* CLD-411|update missing test
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@trankhacvy
Update config file (#167)
84e841c
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@trankhacvy
Merge from develop to master (#168)
3e423b6 
* [CLD-513] Update Toast variant for success case (#165)

* [CLD-513] Update Toast variant for succes case

* [CLD-513] Fix lint error

* Update config file (#167)
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@trankhacvy
fix: #167 fix npm packages dependencies (#176)
a0ff724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trankhacvy trankhacvy

Labels
bug Something isn't working cognitio-auth config-manager Relates to Config Manager package elements Relates to Elements components and utilities front-end Relates to front end issues react-app-scaffolder Relates to React App Scaffolder package ts-definitions Relates to TS Definitions package web-components
Projects
None yet
Milestone
Foundations Alpha Developer Release
Development

No branches or pull requests
3 participants
@willmcvay @trankhacvy @HollyJoyPhillips