Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The DW app should allow IP whitelisting #11294

Closed
willmcvay opened this issue Jul 12, 2024 · 0 comments · Fixed by #11304, #11305 or #11330
Closed

The DW app should allow IP whitelisting #11294

willmcvay opened this issue Jul 12, 2024 · 0 comments · Fixed by #11304, #11305 or #11330
Assignees
Labels
datawarehouse-app Relates to Data Warehouse App feature New feature or request front-end Relates to front end issues

Comments

@willmcvay
Copy link
Contributor

Background context or User story:

There should be a new network page in the DW app to facilitate ip whitelisting

Specification or Acceptance Criteria:

  • Uses https://platform.dev.paas.reapit.cloud/dataMarketplace/swagger/index.html /Customers endpoint
  • New tab at the top called Account or Network
  • New tab should allow users to setup one or more network rules, and be able to specify a name - regex pattern:
    ^[a-z][a-z0-9_]{0,49}$
  • Users should be able to add one or more ips (no limit) to a rule, optionally specifying a CIDR block to specify a range.
  • if no cidr is specified we default to /32 (single ip)
  • users should be able to deactivate a network rule (PUT /customers/{id}/rules/{ruleId}), or enable a network rule (same endpoint)
  • users should be able to add or remove ip addresses
  • Helper text copy: "By default, any external access to your Snowflake account is prohibited. You are required to setup IP policies to ensure access is only granted to addresses you trust. First, setup a network rule specific to a trusted location, and then assign that location's IP addresses to it, before finally enabling the rule on your account. Whilst you can add all IP addresses to one rule, it's recommended to use multiple rules to separate concerns. For example, you may choose to have one rule for your corporate network, and another rule for home office users. This can make management of your rules easier.

For advanced users, it is possible to configure IP address ranges by providing the appropriate CIDR range when configuring the IP addresses against each rule. Depending on your network this may make it easier to maintain your account configuration."

@willmcvay willmcvay added feature New feature or request front-end Relates to front end issues datawarehouse-app Relates to Data Warehouse App labels Jul 12, 2024
@willmcvay willmcvay self-assigned this Jul 12, 2024
willmcvay added a commit that referenced this issue Jul 15, 2024
willmcvay added a commit that referenced this issue Jul 15, 2024
willmcvay added a commit that referenced this issue Jul 16, 2024
willmcvay added a commit that referenced this issue Jul 16, 2024
willmcvay added a commit that referenced this issue Jul 16, 2024
* feat: #11294 adds network ip whitelisting

* feat: #11294 fixes tests

* feat: #11294 adding power bi modal

* feat: #11294 tested locally and tweaked

* feat: #11294 tested locally and tweaked
willmcvay added a commit that referenced this issue Jul 16, 2024
willmcvay added a commit that referenced this issue Jul 24, 2024
willmcvay added a commit that referenced this issue Jul 25, 2024
willmcvay added a commit that referenced this issue Jul 25, 2024
* fix: #11294 adds pagination to ips table

* fix: #11294 tweak pagination

* chore: pre-push fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datawarehouse-app Relates to Data Warehouse App feature New feature or request front-end Relates to front end issues
Projects
None yet
1 participant