Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.8.2 #223

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Release 0.8.2 #223

merged 2 commits into from
Feb 8, 2022

Conversation

audrium
Copy link
Member

@audrium audrium commented Feb 8, 2022 •
edited
Loading

addresses #222

mvidalgarcia
mvidalgarcia reviewed Feb 8, 2022
View reviewed changes
CHANGES.rst Outdated
Version 0.8.2 (2022-02-08)
---------------------------

- Changes dependencies to solve compatibility issues with latest ``Yadage`` version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioning just "latest" might lack some context in the future, what about mentioning the specific version?

setup.py Outdated
"adage==0.10.1", # FIXME remove once yadage>=0.20.2 is compatible.
"yadage==0.20.1", # FIXME remove once yadage>=0.20.2 is compatible.
"yadage-schemas==0.10.6", # FIXME remove once yadage>=0.20.2 is compatible.
"reana-commons[yadage]>=0.8.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should specify upper bounds as we used to have.

Suggested change
"reana-commons[yadage]>=0.8.4",
"reana-commons[yadage]>=0.8.4,<0.9.0",

mvidalgarcia
mvidalgarcia approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@mvidalgarcia mvidalgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reana-dev run-example is green with this PR checked out.

@audrium audrium merged commit 9d311de into reanahub:master Feb 8, 2022
@audrium audrium mentioned this pull request Feb 8, 2022
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidalgarcia mvidalgarcia mvidalgarcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@audrium @mvidalgarcia