Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opensearch): fetch logs from opensearch (#602) #602

Merged

Conversation

jlemesh
Copy link
Member

@jlemesh jlemesh commented Sep 3, 2024

Optionally fetch live workflow and job logs from OpenSearch.

OpenSearch client is configurable via env variables, passed by Helm chart. Defaults are defined in config.py file.

Read the Docs CI builds started to fail, added fix from https://about.readthedocs.com/blog/2024/07/addons-by-default/ in a separate commit.

Related to reanahub/reana#827.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.75%. Comparing base (e36c6a2) to head (46ae9cd).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   75.59%   76.75%   +1.16%     
==========================================
  Files          15       16       +1     
  Lines        1565     1626      +61     
==========================================
+ Hits         1183     1248      +65     
+ Misses        382      378       -4     
Files with missing lines Coverage Δ
reana_workflow_controller/config.py 92.37% <100.00%> (+1.19%) ⬆️
reana_workflow_controller/opensearch.py 100.00% <100.00%> (ø)
reana_workflow_controller/rest/utils.py 82.40% <100.00%> (+1.33%) ⬆️
reana_workflow_controller/rest/workflows_status.py 83.72% <100.00%> (+0.79%) ⬆️

jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Sep 4, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 06e91d4 to 8423d28 Compare September 4, 2024 15:00
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Sep 4, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 8423d28 to 4471a2d Compare September 4, 2024 15:06
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Sep 6, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 4471a2d to a2167cb Compare September 6, 2024 07:03
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Sep 6, 2024
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Sep 16, 2024
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Sep 16, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 204bf90 to ce6c14a Compare September 16, 2024 12:29
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 9, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from ce6c14a to 00fbf00 Compare October 9, 2024 08:35
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 9, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 00fbf00 to f5514de Compare October 9, 2024 09:18
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 9, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from f5514de to 79a288b Compare October 9, 2024 09:26
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 9, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 79a288b to 15ec775 Compare October 9, 2024 11:36
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 9, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 15ec775 to 4415b61 Compare October 9, 2024 11:44
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 14, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 4415b61 to 802bd49 Compare October 14, 2024 10:53
@jlemesh
Copy link
Member Author

jlemesh commented Oct 14, 2024

Read the Docs build fails with:

      /usr/bin/ld: cannot find core/dot_h.o: No such file or directory
      collect2: error: ld returned 1 exit status

jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 14, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 802bd49 to 13c3228 Compare October 14, 2024 13:20
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 14, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 13c3228 to 98f7427 Compare October 14, 2024 13:30
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 14, 2024
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 17, 2024
jlemesh added a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 17, 2024
@jlemesh jlemesh force-pushed the feature_retrieve_logs_from_opensearch branch from 98f7427 to 20d3148 Compare October 17, 2024 11:26
tiborsimko pushed a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 21, 2024
tiborsimko pushed a commit to jlemesh/reana-workflow-controller that referenced this pull request Oct 21, 2024
@tiborsimko tiborsimko force-pushed the feature_retrieve_logs_from_opensearch branch from 20d3148 to 7856218 Compare October 21, 2024 16:25
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely 👍

I've generated new docs/openapi.json, fixed the unit tests due to the presence of new live_logs_enabled property, and slightly amended the commit message.

@tiborsimko tiborsimko force-pushed the feature_retrieve_logs_from_opensearch branch from 7856218 to 46ae9cd Compare October 21, 2024 17:22
@tiborsimko tiborsimko merged commit 46ae9cd into reanahub:master Oct 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants