fix(delete_workflow): set retention rules as inactive (#595) #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 75.11% 75.13% +0.01%
==========================================
Files 15 15
Lines 1475 1476 +1
==========================================
+ Hits 1108 1109 +1
Misses 367 367
|
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Aug 9, 2024
mdonadoni
force-pushed
the
retention-rules-deleted-workflow
branch
from
88e40fe
to
8422040
Compare
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Aug 26, 2024
mdonadoni
force-pushed
the
retention-rules-deleted-workflow
branch
from
8422040
to
bc614b8
Compare
tiborsimko
reviewed
Aug 28, 2024
| int_session = workflow.sessions.first() | ||
| if int_session: | ||
| kwrm = KubernetesWorkflowRunManager(workflow) | ||
| kwrm.stop_interactive_session(int_session.id_) | ||
|
|
||
| if workspace: | ||
| # 2. disable retention rules, as the workspace will be deleted | ||
| workflow.inactivate_workspace_retention_rules() | ||
| # 3. delete the workspace |
There was a problem hiding this comment.
Minor comment: wouldn't it be better to change the order of 2 and 3 so that the actual deletion of files will occur first? Thinking about a possible corner case what if something goes wrong with the retention rule inactivation: at least the files would be deleted by the time we get an exception from that function if we switch the order. (Assuming that the most frequent use case is for the researcher to liberate some disk space.)
mdonadoni
force-pushed
the
retention-rules-deleted-workflow
branch
from
bc614b8
to
680e288
Compare
tiborsimko
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Works well 👍
$ grep -C 1 retention reana.yaml
workspace:
retention_days:
'*.root': 10
$ reana-client run -w test
$ sleep 60
$ reana-client status -w test | grep -cw finished
1
$ reana-client delete -w test
$ kubectl create job --from cronjob/reana-retention-rules-apply reana-retention-rules-apply2
job.batch/reana-retention-rules-apply2 created
$ kubectl logs reana-retention-rules-apply2-p5d9n
Setting the status of all the rules that will be applied to `pending`
Fetching all the pending rules
No rules to be applied!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana-server#693