Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(secrets): adapt to reana-commons secret-handling changes (#583) #583

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

mdonadoni
Copy link
Member

@mdonadoni
Copy link
Member Author

mdonadoni commented May 6, 2024

TODO:

mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request May 6, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Aug 8, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Aug 8, 2024
@mdonadoni mdonadoni marked this pull request as ready for review August 8, 2024 13:37
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Aug 8, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Aug 19, 2024
mdonadoni added a commit to mdonadoni/reana-workflow-controller that referenced this pull request Aug 19, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.13%. Comparing base (fb9923c) to head (d9512fb).
Report is 1 commits behind head on master.

Files Patch % Lines
reana_workflow_controller/rest/utils.py 16.66% 5 Missing ⚠️
reana_workflow_controller/consumer.py 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   74.28%   75.13%   +0.85%     
==========================================
  Files          15       15              
  Lines        1466     1476      +10     
==========================================
+ Hits         1089     1109      +20     
+ Misses        377      367      -10     
Files Coverage Δ
reana_workflow_controller/k8s.py 88.97% <100.00%> (ø)
reana_workflow_controller/workflow_run_manager.py 81.27% <100.00%> (+0.08%) ⬆️
reana_workflow_controller/consumer.py 55.84% <90.00%> (+10.57%) ⬆️
reana_workflow_controller/rest/utils.py 81.06% <16.66%> (-0.73%) ⬇️

@tiborsimko tiborsimko merged commit d9512fb into reanahub:master Aug 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secrets: avoid repeated calls to k8s API
2 participants