ui: add workflow sharing modal #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanRosendal
force-pushed
the
workflow-sharing-modal
branch
from
39fb0f4
to
d69d25e
Compare
DaanRosendal
force-pushed
the
workflow-sharing-modal
branch
from
d69d25e
to
ce95ea1
Compare
Closes #651
DaanRosendal
force-pushed
the
workflow-sharing-modal
branch
2 times, most recently
from
e98e2c3
to
ce8ad2e
Compare
tiborsimko
reviewed
May 3, 2024
| @@ -69,6 +70,17 @@ export default function WorkflowActionsPopup({ workflow, className }) { | |||
| }); | |||
| } | |||
|
|
|||
| menuItems.push({ | |||
| key: "share", | |||
| content: "Share workflow", | |||
There was a problem hiding this comment.
FWIW when testing the PR set:
- r-client: 692
- r-client-go: 153
- r-ui: 375
- r-server: 658
- r-workflow-controller: 552
- r-commons: 429
- r-db: 216
The workflow sharing modal was creating a trackeback on the r-server side:
2024-03-28 13:52:43,318 | root | uWSGIWorker2Core1 | ERROR | share_workflow does not have parameter user
Traceback (most recent call last):
File "/code/./reana_server/rest/workflows.py", line 3397, in share_workflow
response, http_response = current_rwc_api_client.api.share_workflow(
File "/usr/local/lib/python3.8/dist-packages/bravado/client.py", line 246, in __call__
request_params = construct_request(
File "/usr/local/lib/python3.8/dist-packages/bravado/client.py", line 285, in construct_request
construct_params(operation, request, op_kwargs)
File "/usr/local/lib/python3.8/dist-packages/bravado/client.py", line 305, in construct_params
raise SwaggerMappingError(
bravado_core.exception.SwaggerMappingError: share_workflow does not have parameter user
This is because the r-ui PR was not updated yet to send the sharing details via the JSON body rather than via the URL query (used previously).
|
Included in #375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do and discuss
The wireframe depicted in the corresponding issue has been mimicked as closely as possible:
Closes #368