-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(secrets): adapt to reana-commons secret-handling changes (#686) #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
May 6, 2024
…anahub#686) Refactor secrets-related endpoints to adapt to performance-related refactor of `reana-commons`. Improve validation of endpoints' parameters. Closes reanahub/reana-commons#455
mdonadoni
force-pushed
the
secrets-refactor
branch
from
May 6, 2024 14:33
63d2206
to
7309740
Compare
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Aug 8, 2024
…anahub#686) Refactor secrets-related endpoints to adapt to performance-related refactor of `reana-commons`. Improve validation of endpoints' parameters. Closes reanahub/reana-commons#455
mdonadoni
force-pushed
the
secrets-refactor
branch
from
August 8, 2024 11:57
7309740
to
7b0c890
Compare
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Aug 8, 2024
…anahub#686) Refactor secrets-related endpoints to adapt to performance-related refactor of `reana-commons`. Improve validation of endpoints' parameters. Closes reanahub/reana-commons#455
mdonadoni
force-pushed
the
secrets-refactor
branch
from
August 8, 2024 13:09
7b0c890
to
f0929b3
Compare
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Aug 8, 2024
…anahub#686) Refactor secrets-related endpoints to adapt to performance-related refactor of `reana-commons`. Improve validation of endpoints' parameters. Closes reanahub/reana-commons#455
mdonadoni
force-pushed
the
secrets-refactor
branch
from
August 8, 2024 14:20
f0929b3
to
81a489e
Compare
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Aug 19, 2024
…anahub#686) Refactor secrets-related endpoints to adapt to performance-related refactor of `reana-commons`. Improve validation of endpoints' parameters. Closes reanahub/reana-commons#455
mdonadoni
force-pushed
the
secrets-refactor
branch
from
August 19, 2024 10:11
81a489e
to
3a56d7d
Compare
…anahub#686) Refactor secrets-related endpoints to adapt to performance-related refactor of `reana-commons`. Improve validation of endpoints' parameters. Closes reanahub/reana-commons#455
tiborsimko
force-pushed
the
secrets-refactor
branch
from
August 21, 2024 15:05
3a56d7d
to
3596ee0
Compare
tiborsimko
approved these changes
Aug 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #686 +/- ##
==========================================
- Coverage 60.98% 60.87% -0.12%
==========================================
Files 33 33
Lines 3440 3458 +18
==========================================
+ Hits 2098 2105 +7
- Misses 1342 1353 +11
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor secrets-related endpoints to adapt to performance-related
refactor of
reana-commons
. Improve validation of endpoints'parameters.
Closes reanahub/reana-commons#455