rest: add share_workflow endpoint #640
Conversation
Adds a new endpoint to share a workflow with a user. Closes reanahub/reana-client#680
DaanRosendal
force-pushed
the
feature/share-add
branch
from
8551616
to
1f608f6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #640 +/- ##
==========================================
- Coverage 59.41% 59.14% -0.27%
==========================================
Files 32 32
Lines 3294 3314 +20
==========================================
+ Hits 1957 1960 +3
- Misses 1337 1354 +17
|
| "user_email_to_share_with": fields.String(), | ||
| "message": fields.String(missing=None), | ||
| "valid_until": fields.String(missing=None), |
There was a problem hiding this comment.
As for r-workflow-controller, I think we should put these parameters in the body of the request instead of using query parameters
There was a problem hiding this comment.
I agree.
The change has been applied to this superseding PR: #658
| application/json: | ||
| { | ||
| "message": "Malformed request.", | ||
| "errors": ["Missing data for required field."] |
There was a problem hiding this comment.
As for r-workflow-controller, let's remove the errors array if it's not needed, here and in the specification of the other error codes.
There was a problem hiding this comment.
Done.
The change has been applied to this superseding PR: #658
| { | ||
| "errors": ["User is not allowed to share the workflow."] | ||
| } |
There was a problem hiding this comment.
Examples and schema do not match
There was a problem hiding this comment.
Well spotted. Fixed it.
The change has been applied to this superseding PR: #658
| from webargs import fields, validate | ||
| from webargs.flaskparser import use_kwargs |
There was a problem hiding this comment.
As for r-wokflow-controller, please check the order of imports https://github.com/reanahub/reana/wiki/Tips-for-Python#imports
There was a problem hiding this comment.
I'm pretty sure it's correct but I'm a bit short on time. Please double check.
The change has been applied to this superseding PR: #658
| except ValueError as e: | ||
| # In case of invalid workflow name / UUID | ||
| logging.exception(str(e)) | ||
| return jsonify({"message": str(e)}), 403 |
There was a problem hiding this comment.
You are right, thanks.
The change has been applied to this superseding PR: #658
| "message": "Malformed request.", | ||
| "errors": ["Missing data for required field."] | ||
| } | ||
| 403: |
There was a problem hiding this comment.
I think 403 is never returned?
There was a problem hiding this comment.
Actually this can be returned by the signin_required decorator, so let's keep it. We should also add 401, which is also returned by signin_required.
There was a problem hiding this comment.
Added the 401.
The change has been applied to this superseding PR: #658
|
Included in #658 |
Adds a new endpoint to share a workflow with a user.
Closes reanahub/reana-client#680