Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish docker image after new release #634

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

mdonadoni
Copy link
Member

with:
username: ${{ secrets.DOCKER_USER }}
password: ${{ secrets.DOCKER_PASSWORD }}
organisation: reanahub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor musings, we can fully forget them:

  • Perhaps "organisation" could also be a secret so that the setup could be all secretified for a possible theoretical replication elsewhere.

  • I guess we shell be using access tokens, so perhaps we could even name the PASSWORD in a ACCESS_TOKEN style. (Even though the tokens work in place of passwords, so the naming is already OK in this way; just thinking out loud about possible "discouraging" of the use of passwords here via a visible name.)

Copy link
Member Author

@mdonadoni mdonadoni Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added vars.DOCKER_ORGANISATION and vars.DOCKER_REGISTRY (notice vars vs secrets). I am also using the boolean vars.RELEASE_DOCKER so that this job does not run on our own forks

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #634 (a295de7) into master (5b25925) will not change coverage.
The diff coverage is n/a.

❗ Current head a295de7 differs from pull request most recent head 34131ba. Consider uploading reports for the commit 34131ba to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #634   +/-   ##
=======================================
  Coverage   59.41%   59.41%           
=======================================
  Files          32       32           
  Lines        3294     3294           
=======================================
  Hits         1957     1957           
  Misses       1337     1337           

@mdonadoni mdonadoni marked this pull request as ready for review October 26, 2023 12:38
@mdonadoni mdonadoni force-pushed the release-docker branch 2 times, most recently from 866c655 to 9a44298 Compare October 31, 2023 17:17
@mdonadoni mdonadoni force-pushed the release-docker branch 2 times, most recently from 9b4800e to a295de7 Compare November 10, 2023 13:43
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetics: let's capitalise the "name" as in "Release Docker image" for consistency with the other rules we have, and let's order the "needs" alphabetically.

@mdonadoni mdonadoni merged commit 34131ba into reanahub:master Nov 15, 2023
11 checks passed
@mdonadoni mdonadoni deleted the release-docker branch November 15, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: build and push docker images
2 participants