-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: publish docker image after new release #634
Conversation
.github/workflows/release-docker.yml
Outdated
with: | ||
username: ${{ secrets.DOCKER_USER }} | ||
password: ${{ secrets.DOCKER_PASSWORD }} | ||
organisation: reanahub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor musings, we can fully forget them:
-
Perhaps "organisation" could also be a secret so that the setup could be all secretified for a possible theoretical replication elsewhere.
-
I guess we shell be using access tokens, so perhaps we could even name the PASSWORD in a ACCESS_TOKEN style. (Even though the tokens work in place of passwords, so the naming is already OK in this way; just thinking out loud about possible "discouraging" of the use of passwords here via a visible name.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added vars.DOCKER_ORGANISATION
and vars.DOCKER_REGISTRY
(notice vars vs secrets). I am also using the boolean vars.RELEASE_DOCKER
so that this job does not run on our own forks
89e4e5f
to
5ec6183
Compare
5ec6183
to
3b5f05a
Compare
866c655
to
9a44298
Compare
9b4800e
to
a295de7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cosmetics: let's capitalise the "name" as in "Release Docker image" for consistency with the other rules we have, and let's order the "needs" alphabetically.
a295de7
to
34131ba
Compare
Closes reanahub/reana#752