Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_workflow_status: starting workflow should queue it #690

Closed
mdonadoni opened this issue Jun 26, 2024 · 1 comment · Fixed by #691 or reanahub/reana-commons#460
Closed

set_workflow_status: starting workflow should queue it #690

mdonadoni opened this issue Jun 26, 2024 · 1 comment · Fixed by #691 or reanahub/reana-commons#460

Comments

@mdonadoni
Copy link
Member

At the moment, calling set_workflow_status to start a workflow will result in the workflow being executed immediately, as r-server calls directly r-w-controller:

if not workflow_id_or_name:
raise ValueError("workflow_id_or_name is not supplied")
status = request.args.get("status")
parameters = request.json if request.is_json else None
response, http_response = current_rwc_api_client.api.set_workflow_status(
user=str(user.id_),
workflow_id_or_name=workflow_id_or_name,
status=status,
parameters=parameters,
).result()

Note that we have a second start_workflow endpoint which correctly queues the workflow:

def start_workflow(workflow_id_or_name, user): # noqa

@mdonadoni mdonadoni self-assigned this Jul 1, 2024
mdonadoni added a commit to mdonadoni/reana-server that referenced this issue Jul 1, 2024
…ahub#691)

When starting a new workflow, publish the workflow to the submission
queue instead of executing the workflow immediately by calling
`set_workflow_status` in workflow-controller.

Closes reanahub#690
mdonadoni added a commit to mdonadoni/reana-server that referenced this issue Jul 1, 2024
…ahub#691)

When starting a new workflow, publish the workflow to the submission
queue instead of executing the workflow immediately by calling
`set_workflow_status` in workflow-controller.

Closes reanahub#690
mdonadoni added a commit to mdonadoni/reana-server that referenced this issue Jul 2, 2024
…ahub#691)

When starting a new workflow, publish the workflow to the submission
queue instead of executing the workflow immediately by calling
`set_workflow_status` in workflow-controller.

Closes reanahub#690
@mdonadoni mdonadoni added this to 0.9.4 Jul 2, 2024
@mdonadoni mdonadoni moved this to In review in 0.9.4 Jul 2, 2024
mdonadoni added a commit to mdonadoni/reana-server that referenced this issue Jul 2, 2024
…ahub#691)

When starting a new workflow, publish the workflow to the submission
queue instead of executing the workflow immediately by calling
`set_workflow_status` in workflow-controller.

Closes reanahub#690
mdonadoni added a commit to mdonadoni/reana-commons that referenced this issue Jul 2, 2024
mdonadoni added a commit to mdonadoni/reana-server that referenced this issue Jul 3, 2024
…ahub#691)

When starting a new workflow, publish the workflow to the submission
queue instead of executing the workflow immediately by calling
`set_workflow_status` in workflow-controller.

Closes reanahub#690
mdonadoni added a commit to mdonadoni/reana-commons that referenced this issue Jul 3, 2024
mdonadoni added a commit to mdonadoni/reana-server that referenced this issue Jul 3, 2024
…ahub#691)

When starting a new workflow, publish the workflow to the submission
queue instead of executing the workflow immediately by calling
`set_workflow_status` in workflow-controller.

Closes reanahub#690
@mdonadoni mdonadoni moved this from In review to Done in 0.9.4 Jul 4, 2024
@mdonadoni
Copy link
Member Author

Done: #691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment