Skip to content

Commit

Permalink
fix(reana-admin): respect service domain when cleaning sessions (#687)
Browse files Browse the repository at this point in the history
Removes hard-coded infrastructure component host name domain
"svc.local.cluster" during interactive session clean-up procedures,
since this assumption is not really necessary and would not work under
some deployment scenarios, such as on SSL-RIVER.

Closes reanahub/reana#457
  • Loading branch information
tiborsimko committed May 6, 2024
1 parent fbf6ba1 commit 249180b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions reana_server/reana_admin/cli.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
#
# This file is part of REANA.
# Copyright (C) 2020, 2021, 2022 CERN.
# Copyright (C) 2020, 2021, 2022, 2024 CERN.
#
# REANA is free software; you can redistribute it and/or modify it
# under the terms of the MIT License; see LICENSE file for more details.
Expand Down Expand Up @@ -1077,7 +1077,7 @@ def interactive_session_cleanup(

try:
session_status = requests.get(
f"http://reana-run-session-{workflow_id}.{REANA_RUNTIME_KUBERNETES_NAMESPACE}.svc.cluster.local:8081/{workflow_id}/api/status",
f"http://reana-run-session-{workflow_id}.{REANA_RUNTIME_KUBERNETES_NAMESPACE}:8081/{workflow_id}/api/status",
headers={"Authorization": f"token {token}"},
).json()
except Exception as e:
Expand Down

0 comments on commit 249180b

Please sign in to comment.