Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job-monitor: consider OOMKilled pods as failed #397

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

mdonadoni
Copy link
Member

  • job-monitor: consider OOMKilled pods as failed
  • tests: add support for podman

Closes #396

Note that this PR depends on #393

@mdonadoni mdonadoni marked this pull request as draft August 9, 2023 11:12
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #397 (0872804) into master (6b92e4d) will increase coverage by 0.24%.
The diff coverage is 78.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   47.69%   47.93%   +0.24%     
==========================================
  Files          17       17              
  Lines        1128     1139      +11     
==========================================
+ Hits          538      546       +8     
- Misses        590      593       +3     
Files Changed Coverage Δ
reana_job_controller/job_monitor.py 46.86% <78.57%> (+1.09%) ⬆️

@mdonadoni mdonadoni marked this pull request as ready for review August 15, 2023 11:39
Copy link
Member

@giuseppe-steduto giuseppe-steduto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mdonadoni mdonadoni merged commit 0872804 into reanahub:master Aug 16, 2023
11 checks passed
@mdonadoni mdonadoni deleted the oomkilled branch August 16, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

job_monitor: OOMKilled job is sometimes considered successful
2 participants