docs: fix ReadTheDocs build #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
force-pushed
the
18-amend-imports
branch
2 times, most recently
from
679f3b4
to
d68d88c
Compare
* Adds `config.py` so that pykube configuration is loaded only at run time. (closes reanahub#18) * Renames `create_job` on `k8s.py` to avoid name clashing inside `app.py`. Signed-off-by: Diego Rodriguez <[email protected]>
diegodelemos
force-pushed
the
18-amend-imports
branch
from
d68d88c
to
9c0e67a
Compare
tiborsimko
reviewed
Feb 7, 2017
|
|
||
| import pykube | ||
|
|
||
| # FIXME do not share HTTPClient but only config |
There was a problem hiding this comment.
I merged this PR since it fixed the REST API docs 👍 and since this line has a FIXME so it'll get refactored soon... Let's see IRL because it doesn't seem that nice to keep the config.py file outside of the package scope?
roksys
pushed a commit
to roksys/reana-job-controller
that referenced
this pull request
Oct 18, 2018
* Improves REST API docs rendering. Closes reanahub#25 Signed-off-by: Rokas Maciulaitis <[email protected]>
ghost
assigned
roksys
pushed a commit
to roksys/reana-job-controller
that referenced
this pull request
Oct 19, 2018
* Improves REST API docs rendering. Closes reanahub#25 Signed-off-by: Rokas Maciulaitis <[email protected]>
roksys
pushed a commit
to roksys/reana-job-controller
that referenced
this pull request
Oct 23, 2018
* Improves REST API docs rendering. Closes reanahub#25 Signed-off-by: Rokas Maciulaitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
config.pyso that pykube configuration is loaded only atrun time. (closes docs: amend imports to remove autodoc mocking #18)
Renames
create_jobonk8s.pyto avoid name clashing insideapp.py.Signed-off-by: Diego Rodriguez [email protected]