Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(commitlint): addition of commit message linter #218

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

tiborsimko
Copy link
Member

Adds commitlint to check the commit message style against agreed
conventional commits configuration.

Changes script argument values to always use linter names (e.g.
shellcheck).

Changes argument handling to allow only one checking action that can now
accept further optional arguments.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6cfee4b) 74.50% compared to head (8c44893) 74.50%.
Report is 1 commits behind head on master.

❗ Current head 8c44893 differs from pull request most recent head 7c616d6. Consider uploading reports for the commit 7c616d6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   74.50%   74.50%           
=======================================
  Files           7        7           
  Lines         902      902           
=======================================
  Hits          672      672           
  Misses        230      230           
Files Coverage Δ
reana_db/version.py 0.00% <0.00%> (ø)

tiborsimko added a commit to tiborsimko/reana-db that referenced this pull request Jan 10, 2024
Adds commitlint to check the commit message style against agreed
conventional commits configuration.

Changes script argument values to always use linter names (e.g.
shellcheck).

Changes argument handling to allow only one checking action that can now
accept further optional arguments.
tiborsimko added a commit to tiborsimko/reana-db that referenced this pull request Jan 10, 2024
tiborsimko added a commit to tiborsimko/reana-db that referenced this pull request Jan 10, 2024
Adds commitlint to check the commit message style against agreed
conventional commits configuration.

Changes script argument values to always use linter names (e.g.
shellcheck).

Changes argument handling to allow only one checking action that can now
accept further optional arguments.
@tiborsimko tiborsimko closed this Jan 12, 2024
@tiborsimko tiborsimko deleted the commitlint branch January 12, 2024 12:51
@tiborsimko tiborsimko merged commit 7c616d6 into reanahub:master Jan 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants