Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow customising currently hard-coded service hostnames #457

Closed
tiborsimko opened this issue May 3, 2024 · 0 comments · Fixed by #458 or reanahub/reana-server#687
Closed

allow customising currently hard-coded service hostnames #457

tiborsimko opened this issue May 3, 2024 · 0 comments · Fixed by #458 or reanahub/reana-server#687
Assignees

Comments

@tiborsimko
Copy link
Member

We have currently hard-coded component hostnames in config.py:

REANA_INFRASTRUCTURE_COMPONENTS_HOSTNAMES = {
    component_name: (
        "{component_prefix}-{component_name}.{namespace}.svc.cluster.local"
    ).format(
        component_prefix=REANA_COMPONENT_PREFIX,
        component_name=component_name,
        namespace=REANA_INFRASTRUCTURE_KUBERNETES_NAMESPACE,
    )
    for component_name in REANA_INFRASTRUCTURE_COMPONENTS
}
"""REANA infrastructure pods hostnames.

This causes troubles for the RIVER-SSL deployment due to using different domain.

(See also the ClusterRole to Role tentative changes here: https://github.com/reanahub/reana/pull/291/files that may or may not be needed.)

Basically, instead of always appending svc.cluster.local, we could make this part customisable via Helm values.

Note that the reana-server component is also concerned:

$ rg svc.cluster.local
• reana_server/reana_admin/cli.py
1080:                f"http://reana-run-session-{workflow_id}.{REANA_RUNTIME_KUBERNETES_NAMESPACE}.svc.cluster.local:8081/{workflow_id}/api/status",
@tiborsimko tiborsimko self-assigned this May 6, 2024
tiborsimko added a commit to tiborsimko/reana-commons that referenced this issue May 6, 2024
Remove hard-coded infrastructure component host name domain
"svc.local.cluster", since this assumption is not really necessary and
made REANA not to work under some deployment scenarios, such as on
SSL-RIVER.

Closes reanahub#457
tiborsimko added a commit to tiborsimko/reana-commons that referenced this issue May 6, 2024
Remove hard-coded infrastructure component host name domain
"svc.local.cluster", since this assumption is not really necessary and
made REANA not to work under some deployment scenarios, such as on
SSL-RIVER.

Closes reanahub#457
tiborsimko added a commit to tiborsimko/reana-commons that referenced this issue May 6, 2024
Removes hard-coded infrastructure component host name domain
"svc.local.cluster", since this assumption is not really necessary and
made REANA not to work under some deployment scenarios, such as on
SSL-RIVER.

Closes reanahub#457
tiborsimko added a commit to tiborsimko/reana-server that referenced this issue May 15, 2024
…ahub#687)

Removes hard-coded infrastructure component host name domain
"svc.local.cluster" during interactive session clean-up procedures,
since this assumption is not really necessary and would not work under
some deployment scenarios, such as on SSL-RIVER.

Closes reanahub/reana-commons#457
@mdonadoni mdonadoni self-assigned this May 15, 2024
@mdonadoni mdonadoni added this to 0.9.4 Jun 27, 2024
@mdonadoni mdonadoni moved this to Done in 0.9.4 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment