ci(tox): fix collecting code coverage information #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
added a commit
to tiborsimko/reana-client
that referenced
this pull request
Aug 22, 2024
Fixes `tox` configuration with respect to installing all optional package dependencies that are necessary for running various tests. Fixes `tox` collecting of code coverage information by forcing editable mode also in the test running instructions.
tiborsimko
force-pushed
the
tox-coverage
branch
from
a0e1aef
to
a97dfd1
Compare
tiborsimko
commented
Aug 22, 2024
| py39 | ||
| py310 | ||
| py311 | ||
| py312 |
There was a problem hiding this comment.
Note: for Python 3.12, to run tox -e py312 locally, we need to first release new pytest-reana that is bumping the limit of the coverage dependency. This is done in reanahub/pytest-reana#134
There was a problem hiding this comment.
$ sudo dnf install python3.8 python3.9 python3.10 python3.11 python3.12
$ sudo dnf install python3.10-devel python3.11-devel python3.12-devel
$ tox --skip-env py312
...
py38: OK (43.40=setup[14.36]+cmd[11.09,17.95] seconds)
py39: OK (55.55=setup[21.52]+cmd[16.22,17.80] seconds)
py310: OK (54.54=setup[20.63]+cmd[15.61,18.31] seconds)
py311: OK (73.71=setup[1.25]+cmd[5.53,66.94] seconds)
congratulations :) (227.31 seconds)
mdonadoni
reviewed
Aug 26, 2024
tox.ini
Outdated
| pytest | ||
| pytest-cov | ||
| commands = | ||
| pip install -e .[all] |
There was a problem hiding this comment.
Shall we use extras instead of manually installing the packages in commands? https://tox.wiki/en/latest/config.html#extras
Fixes `tox` configuration with respect to installing all optional package dependencies that are necessary for running various tests. Fixes `tox` collecting of code coverage information by forcing editable mode when running tests.
tiborsimko
force-pushed
the
tox-coverage
branch
from
a97dfd1
to
cd45ad5
Compare
mdonadoni
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
toxconfiguration with respect to installing all optional package dependencies that are necessary for running various tests.Fixes
toxcollecting of code coverage information by forcing editable mode also in the test running instructions.