Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: duration of stopped workflows is not displayed correctly #699

Closed
giuseppe-steduto opened this issue Jan 25, 2024 · 0 comments · Fixed by #701, reanahub/reana-client-go#156 or #697
Closed

cli: duration of stopped workflows is not displayed correctly #699

giuseppe-steduto opened this issue Jan 25, 2024 · 0 comments · Fixed by #701, reanahub/reana-client-go#156 or #697
Assignees
@mdonadoni @giuseppe-steduto
Labels
priority/soon type/bug

Comments

@giuseppe-steduto
Copy link
Member

Similarly to what was happening in reanahub/reana-ui#386, when running reana-client status --include-duration for a stopped workflow, the displayed duration is not the time between the moment in which the run was started and the moment in which the run was stopped, but the total time passed from the beginning of the run until the current moment.

❯ reana-client status -w recast --include-duration --json | jq '.[0].status'
"stopped"
❯ reana-client status -w recast --include-duration --json | jq '.[0].duration'
2598
# After a few seconds...
❯ reana-client status -w recast --include-duration --json | jq '.[0].duration'
2604

This is very likely because in reana_client.utils.get_workflow_duration we only look at run_finished_at, but not at run_stopped_at.
giuseppe-steduto added a commit to giuseppe-steduto/reana-client that referenced this issue Jan 26, 2024
@giuseppe-steduto
test: allow Snakemake tests to run on newer Python versions (reanahub…
bbc98c6 
…#699)

After upgrading Snakemake to version 7.32.4 (reanahub/reana-commons#435)
there is no need to avoid running Snakemake tests on Python 3.11 and
3.12, as it should be supported.

Closes reanahub#655
@giuseppe-steduto giuseppe-steduto self-assigned this Jan 29, 2024
giuseppe-steduto added a commit to giuseppe-steduto/reana-client that referenced this issue Jan 29, 2024
@giuseppe-steduto
fix(status): correctly display duration of stopped workflows (reanahu…
d3925f2 
…b#701)

Closes reanahub#699
@giuseppe-steduto giuseppe-steduto mentioned this issue Jan 29, 2024
Merged
giuseppe-steduto added a commit to giuseppe-steduto/reana-client-go that referenced this issue Jan 29, 2024
@giuseppe-steduto
fix(status): correctly display duration of stopped workflows (reanahu…
d1a8ae9 
…b#156)

Closes reanahub/reana-client#699
@giuseppe-steduto giuseppe-steduto mentioned this issue Jan 29, 2024
Closed
giuseppe-steduto added a commit to giuseppe-steduto/reana-client-go that referenced this issue Jan 29, 2024
@giuseppe-steduto
fix(status): correctly display duration of stopped workflows (reanahu…
233c616 
…b#156)

Closes reanahub/reana-client#699
@giuseppe-steduto giuseppe-steduto mentioned this issue Jan 29, 2024
Merged
@mdonadoni mdonadoni self-assigned this Feb 1, 2024
@github-actions github-actions bot mentioned this issue Feb 1, 2024
Merged
giuseppe-steduto added a commit to giuseppe-steduto/reana-client-go that referenced this issue Feb 27, 2024
@giuseppe-steduto
fix(status): correctly display duration of stopped workflows (reanahu…
89c4b7e 
…b#156)

Closes reanahub/reana-client#699
mdonadoni pushed a commit to giuseppe-steduto/reana-client-go that referenced this issue Mar 14, 2024
@giuseppe-steduto @mdonadoni
fix(status): correctly display duration of stopped workflows (reanahu…
d3db6c1 
…b#156)

Closes reanahub/reana-client#699
mdonadoni added a commit to giuseppe-steduto/reana-client-go that referenced this issue Mar 14, 2024
@giuseppe-steduto @mdonadoni
fix(status): correctly display duration of stopped workflows (reanahu…
3b7da05 
…b#156)

Closes reanahub/reana-client#699

Co-authored-by: Marco Donadoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdonadoni mdonadoni

@giuseppe-steduto giuseppe-steduto

Labels
priority/soon type/bug
Projects
None yet
Milestone
No milestone
2 participants
@mdonadoni @giuseppe-steduto