New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: implement list --shared argument #153

Merged

tiborsimko merged 6 commits into reanahub:master from DaanRosendal:feature/list-shared

Sep 4, 2024

Member

DaanRosendal commented Nov 21, 2023

Adds new --shared, --shared-by, and --shared-with arguments to the
list CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687

DaanRosendal force-pushed the feature/list-shared branch 3 times, most recently from ad67929 to 9f17a06 Compare

March 18, 2024 10:34

DaanRosendal added a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement share-add command (reanahub#153)

a07306c

Adds a new command to the CLI to share a workflow with a user.

Closes reanahub/reana-client#680

DaanRosendal added a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement share-remove command (reanahub#153)

b9d3f19

Adds a new command to the CLI to unshare a workflow.

Closes reanahub/reana-client#681

DaanRosendal added a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement share-status command (reanahub#153)

3adb48c

Adds a new command to the CLI to retrieve whom a workflow is shared
with.

Closes reanahub/reana-client#686

DaanRosendal force-pushed the feature/list-shared branch from 9f17a06 to 8962641 Compare

March 18, 2024 16:28

DaanRosendal added a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement list --shared argument (reanahub#153)

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687

DaanRosendal added a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement share-add command (reanahub#153)

f90b17c

Adds a new command to the CLI to share a workflow with a user.

Closes reanahub/reana-client#680

DaanRosendal added a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement share-remove command (reanahub#153)

0b0049a

Adds a new command to the CLI to unshare a workflow.

Closes reanahub/reana-client#681

DaanRosendal added a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement share-status command (reanahub#153)

68a1072

Adds a new command to the CLI to retrieve whom a workflow is shared
with.

Closes reanahub/reana-client#686

DaanRosendal force-pushed the feature/list-shared branch from 8962641 to 5a0c4e4 Compare

March 18, 2024 16:49

DaanRosendal added a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement list --shared argument (reanahub#153)

5a0c4e4

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687

DaanRosendal mentioned this pull request

cli: implement share-add command #148

Closed

This was referenced Aug 20, 2024

cli: implement share-status command #151

Closed

cli: implement share-remove command #149

Closed

mdonadoni pushed a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement share-add command (reanahub#153)

04193a9

Adds a new command to the CLI to share a workflow with a user.

Closes reanahub/reana-client#680

mdonadoni pushed a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement share-remove command (reanahub#153)

d1e958f

Adds a new command to the CLI to unshare a workflow.

Closes reanahub/reana-client#681

mdonadoni force-pushed the feature/list-shared branch from 5a0c4e4 to a568abd Compare

August 20, 2024 15:08

mdonadoni pushed a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement share-status command (reanahub#153)

318bcf6

Adds a new command to the CLI to retrieve whom a workflow is shared
with.

Closes reanahub/reana-client#686

mdonadoni pushed a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(cli): implement list --shared argument (reanahub#153)

a568abd

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687

Member

mdonadoni commented Aug 20, 2024

Latest version before rebase: 5a0c4e4

mdonadoni added a commit to DaanRosendal/reana-client-go that referenced this pull request


          chore(client): update swagger client (reanahub#153)

d3f6494

mdonadoni added a commit to DaanRosendal/reana-client-go that referenced this pull request


          fix(cmd): update workflow sharing commands after rebase (reanahub#153)

14593d9

codecov bot commented Aug 29, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 81.85484% with 45 lines in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (c9f0e01) to head (955bda8).
Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/share_status.go	49.35%	37 Missing and 2 partials ⚠️
cmd/share_add.go	94.36%	2 Missing and 2 partials ⚠️
cmd/share_remove.go	96.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   85.79%   85.44%   -0.36%     
==========================================
  Files          38       41       +3     
  Lines        2675     2919     +244     
==========================================
+ Hits         2295     2494     +199     
- Misses        293      333      +40     
- Partials       87       92       +5

Files with missing lines	Coverage Δ
cmd/list.go	`95.52% <100.00%> (+0.58%)`	⬆️
cmd/ls.go	`94.69% <100.00%> (ø)`
cmd/root.go	`84.71% <100.00%> (+0.71%)`	⬆️
cmd/secrets_add.go	`97.29% <ø> (-0.08%)`	⬇️
cmd/share_remove.go	`96.66% <96.66%> (ø)`
cmd/share_add.go	`94.36% <94.36%> (ø)`
cmd/share_status.go	`49.35% <49.35%> (ø)`

Member

mdonadoni commented Aug 29, 2024

Ready to be reviewed, squashed and merged

tiborsimko approved these changes

View reviewed changes

Member

tiborsimko left a comment

Works niclely 👍 with

- r-client #692
- r-client-go #153
- r-ui #375
- r-server #658
- r-workflow-controller #552
- r-commons #429
- r-db #216

Kept separate commits, rephrased some commit log headlines.

DaanRosendal added 3 commits

September 4, 2024 19:45


          feat(share-add): add workflow sharing command (reanahub#153)

daa60e0

Adds a new command to the CLI to share a workflow with a user.

Closes reanahub/reana-client#680


          feat(share-remove): add workflow unsharing command (reanahub#153)

7a0a84a

Adds a new command to the CLI to unshare a workflow.

Closes reanahub/reana-client#681


          feat(share-status): add workflow sharing status command (reanahub#153)

04a33c5

Adds a new command to the CLI to retrieve whom a workflow is shared
with.

Closes reanahub/reana-client#686

tiborsimko force-pushed the feature/list-shared branch from 14593d9 to c360b88 Compare

September 4, 2024 17:49

tiborsimko pushed a commit to DaanRosendal/reana-client-go that referenced this pull request


          feat(list): add sharing-related arguments (reanahub#153)

c5091b0

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687

tiborsimko pushed a commit to DaanRosendal/reana-client-go that referenced this pull request


          chore(client): update swagger client (reanahub#153)

a719cdf

tiborsimko pushed a commit to DaanRosendal/reana-client-go that referenced this pull request


          fix(cmd): update workflow sharing commands after changes (reanahub#153)

c360b88

DaanRosendal and others added 3 commits

September 4, 2024 19:50


          feat(list): add share-related arguments (reanahub#153)

5d964d2

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub/reana-client#687


          chore(client): update swagger client (reanahub#153)

b7ead37


          fix(cmd): update workflow sharing commands after changes (reanahub#153)

955bda8

tiborsimko force-pushed the feature/list-shared branch from c360b88 to 955bda8 Compare

September 4, 2024 17:51

tiborsimko merged commit 955bda8 into reanahub:master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet