-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ppx jane from prelude #3313
Conversation
Note that there's a bunch of whitespace-only changes here that for some reason Github is incompetent at hiding, even when you turn on whitespace hiding. If you look at the diff in Patdiff, everything looks fine. |
@NathanReb there's a strange anomaly in environment variable handling. If I run this PR with
...it passes the expect test. However, forcing the env-var in either dune-workspace with:
fails to force it, and the expect tests fail. The minimal place to force the env-var to be set would be in the |
Have you tried setting it with MDX labels? It should work and might be a good work around until we figured this out! |
I.e. adding |
For now, I've added non-determinism markers. We can remove them when we have a solution. |
Remove ppx_jane and open Base from a bunch of prelude.ml files. This required a bunch of follow-on changes to merge env's together, and to add some #require's to explicitly turn on syntax extensions. This all seems good.
There are some weird corners, notably, for some reason ppx_sexp_conv doesn't seem to work when #require'd, but ppx_jane does. I posted on issue there, and will fix this when that is resolved:
janestreet/ppx_sexp_conv#30