-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compability issues on Windows #22
base: LinkStage3
Are you sure you want to change the base?
Conversation
I think most of them are minor fixes, and they won't affect the structure of the project. |
Can you please elaborate the reason of the changes? Do they cause compilation error? Which compiler do you use? Also, the flex generated file, any reason you re-generate it? |
Hi, yes, I was using Visual Studio 2019 (the latest update). Those changed contents can fix all the compilation errors I encountered. I didn't know why I generated the flex file, I think it's not related to fixing those compilation errors. I would be happy to remove this committed file if you thought the other commits are acceptable. |
Yes, please revert that file and try again to see if there is any error. Also, can you please change SoFCSelectionRoot::PASSTHROUGH to PASS_THROUGH and see if it is okay? |
255a123
to
10a4cc2
Compare
1830a52
to
27c53b4
Compare
8a97ad7
to
fac530c
Compare
73f279b
to
c1d8e4d
Compare
d8c33d8
to
e3d5306
Compare
b6d6691
to
fa87413
Compare
e0a9465
to
6f26068
Compare
6f26068
to
41ac21a
Compare
be55e98
to
9732f5f
Compare
488f041
to
bf876dc
Compare
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:
git pull --rebase upstream master
./bin/FreeCAD --run-test 0
issue #<id>
orfixes #<id>
where<id>
is the associated MantisBT issue id if one existsAnd please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.