Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dcument recomputing failed #905

Closed
vovodroid opened this issue Nov 9, 2023 · 6 comments
Closed

Dcument recomputing failed #905

vovodroid opened this issue Nov 9, 2023 · 6 comments

Comments

@vovodroid
Copy link

Recomputing of FreeCAD document failed

Direct-steel.zip

FreeCADLink version: FreeCAD-Link-Tip-Win-x86_64-py3.11-20230811

@GinTonic99
Copy link

You might consider reading the error messsages, identify the erroneous sketches by looking for exclamation marks in the hierarchy and repairing the defect sketches

@vovodroid
Copy link
Author

Sure I can. But it's supposed to be recomputed automatically.

@GinTonic99
Copy link

Without you having repaired the faulty sketches, no recompute is possible; neither manually nor automatically.

@vovodroid
Copy link
Author

vovodroid commented Nov 12, 2023 via email

realthunder added a commit that referenced this issue Nov 14, 2023
Upstream sketch based feature inherits the placement of the previous
(base) feature, which is deprecated here to avoid unexpected orientation
change of sketch mapping base. This patch ensures the legacy behavior on
migrated project.

Fixes #905
@realthunder
Copy link
Owner

The above commit fixes the problem. You can try by either compile FreeCAD yourself, or wait till the next release.

There is still one recompute failure in BaseSketch001 (i.e. Sketch023). If you double click the sketch to edit, it will complain of Invalid sketch, which may happen if you somehow saved your project while editing the sketch. The upstream FreeCAD reports the same thing if you try to edit the sketch, but the error does not show up if you recompute, which is arguably not a desired behavior.

@vovodroid
Copy link
Author

The above commit fixes the problem

Great!

You can try by either compile FreeCAD yourself

Well, I tried it in the past, but without success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants