Sample code for the Click article #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzaczynski
reviewed
Aug 16, 2023
python-click/add.py
Outdated
| def cli(): | ||
| a = click.prompt("Enter an integer", type=click.INT, default=0) | ||
| b = click.prompt("Enter another integer", type=click.INT, default=0) | ||
|
|
There was a problem hiding this comment.
Do we need this extra blank line here?
bzaczynski
reviewed
Aug 16, 2023
| cli.add_command(commands.sub) | ||
| cli.add_command(commands.mul) | ||
| cli.add_command(commands.div) | ||
|
|
There was a problem hiding this comment.
There should be two blank lines here for consistency.
bzaczynski
reviewed
Aug 16, 2023
| cli.add_command(commands.sub) | ||
| cli.add_command(commands.mul) | ||
| cli.add_command(commands.div) | ||
|
|
There was a problem hiding this comment.
Should there be two blank lines here as well?
bzaczynski
reviewed
Aug 16, 2023
python-click/nasa.py
Outdated
| @@ -0,0 +1,40 @@ | |||
| # nasa.py | |||
There was a problem hiding this comment.
This comment is redundant.
bzaczynski
reviewed
Aug 16, 2023
python-click/greet.py
Outdated
Comment on lines
5
to
8
| @click.option( | ||
| "--name", | ||
| multiple=True, | ||
| ) |
There was a problem hiding this comment.
Collapse these into a single line?
bzaczynski
reviewed
Aug 16, 2023
python-click/ls_v4.py
Outdated
Comment on lines
26
to
27
| if i < len(paths) - 1: | ||
| click.echo() |
There was a problem hiding this comment.
Suggested change:
Suggested change
| if i < len(paths) - 1: | |
| click.echo() | |
| if i < len(paths) - 1: | |
| click.echo("" if long else "\n") | |
| elif not long: | |
| click.echo() |
bzaczynski
reviewed
Aug 16, 2023
python-click/ls_v5.py
Outdated
| for entry in path.iterdir(): | ||
| entry_output = build_output(entry, long) | ||
| click.echo(f"{entry_output:{len(entry_output) + 5}}", nl=long) | ||
| click.echo("\n") |
There was a problem hiding this comment.
Suggested change:
Suggested change
| click.echo("\n") | |
| if i < len(paths) - 1: | |
| click.echo("" if long else "\n") | |
| elif not long: | |
| click.echo() |
bzaczynski
reviewed
Aug 16, 2023
python-click/ls_v6.py
Outdated
| for entry in path.iterdir(): | ||
| entry_output = build_output(entry, long) | ||
| click.echo(f"{entry_output:{len(entry_output) + 5}}", nl=long) | ||
| click.echo("\n") |
There was a problem hiding this comment.
Suggested change:
Suggested change
| click.echo("\n") | |
| if i < len(paths) - 1: | |
| click.echo("" if long else "\n") | |
| elif not long: | |
| click.echo() |
bzaczynski
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
@lpozo Hey, I'm approving this PR but I wanted to let you know that I left some suggestions for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where to put new files:
my-awesome-articleHow to merge your changes: