Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add materials for the Code Image Generator tutorial #411

Merged
merged 16 commits into from
Aug 15, 2023

Conversation

acsany
Copy link
Contributor

@acsany acsany commented Jul 6, 2023

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

@acsany acsany requested a review from lpozo July 6, 2023 12:39
lpozo
lpozo previously requested changes Aug 10, 2023
Copy link
Contributor

@lpozo lpozo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acsany Hey!

I flagged a few details in the steps. It'd be nice to fully check the code with the article.

I typically create the step folders once I finish the TR updates. At this point, it should be a matter of following the article.

Comment on lines 1 to 6
{% extends "base.html" %}
{% block title %}
- Code Input
{% endblock title %}
{% block content %}
{% endblock content %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add the spaces to match the code in the article.

)

app = Flask(__name__)
app.secret_key = "mysecretkey"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using this secret key any longer.

Comment on lines 45 to 47
flex-wrap: wrap;

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flex-wrap: wrap;
}
flex-wrap: wrap;
}

from pygments.styles import get_all_styles

app = Flask(__name__)
app.secret_key = "mysecretkey"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secret_key

Comment on lines 45 to 47
flex-wrap: wrap;

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flex-wrap: wrap;
}
flex-wrap: wrap;
}

Comment on lines 7 to 8
Code to Image {% block title %}{% endblock %}
Code to Image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Code to Image {% block title %}{% endblock %}
Code to Image
Code to Image {% block title %}{% endblock %}

@KateFinegan KateFinegan merged commit 09e95ec into master Aug 15, 2023
1 check passed
@KateFinegan KateFinegan deleted the code-image-generator branch August 15, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants