RJS-2913: Supporting React Native v0.76.0 #6912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
approved these changes
Oct 28, 2024
| @@ -23,7 +23,7 @@ import { act, fireEvent, render, renderHook, waitFor } from "@testing-library/re | |||
| import { AppProvider, useApp } from "../AppProvider"; | |||
| import { Realm } from "realm"; | |||
|
|
|||
| jest.mock("react-native/Libraries/Animated/NativeAnimatedHelper"); | |||
| // jest.mock("react-native/Libraries/Animated/NativeAnimatedHelper"); | |||
There was a problem hiding this comment.
Should it be left as a comment or just removed?
There was a problem hiding this comment.
To be honest, I don't understand the original need for this line and the file is missing in the latest version of React Native, leading to a test failure.
I left it as a comment to make it easier to search for and blame if it starts failing 🙈
There was a problem hiding this comment.
Fair enough, although maybe it'd be good to have a short comment just stating that
kraenhansen
force-pushed
the
kh/react-native-0.76.0
branch
from
fbc99bd
to
2a6d2ae
Compare
kraenhansen
force-pushed
the
kh/react-native-0.76.0
branch
from
2a6d2ae
to
e95732a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This upgrades our test app to use React Native 0.76.0 and closes #6910 and #6908.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary@realm/devdocsif documentation changes are needed