Creating symlinks for ccache on CI instead of modifying PATH
#6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
T-Internal
no-changelog
no-jira-ticket
kraenhansen
commented
Jun 20, 2024
Comment on lines
-191
to
-194
| # in CI file timestamps change with every run so instead rely on file content hashing | ||
| # https://reactnative.dev/docs/build-speed#using-this-approach-on-a-ci | ||
| - name: Configure ccache | ||
| run: ccache --set-config="compiler_check=content" |
There was a problem hiding this comment.
As per hendrikmuhs/ccache-action#147 this is already set by the action on macOS.
kraenhansen
commented
Jun 20, 2024
Comment on lines
-186
to
-189
| - name: Prepend ccache executables to the PATH | ||
| if: ${{ runner.os != 'Windows' }} | ||
| run: | | ||
| echo "/usr/lib/ccache:/usr/local/opt/ccache/libexec" >> $GITHUB_PATH |
There was a problem hiding this comment.
The action will create symlinks in /usr/local/bin, which is why we no longer need to modify the path.
|
I included this in #6746 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
I hope this will help CI use ccache more (it seems the integration test job for RN iOS isn't hitting caches at all).