Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide guidance when Realm binary is missing #6061

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Conversation

takameyer
Copy link
Contributor

What, How & Why?

It was not clear when the Realm binary was missing and how to fix it. This provides a pre-check for the Realm binary and throws an error messaging reporting what the problem is. A section has been added to the README.md which provides various tips to fix the problem

This closes #5981

image

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated

@takameyer takameyer merged commit bf251c4 into main Aug 11, 2023
29 of 32 checks passed
@takameyer takameyer deleted the andrew/realm-check branch August 11, 2023 13:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a meaningful error message when the Realm binary is not bound to the JS environment
3 participants