Add common js module to realm/react #6050
Conversation
* fixes jest testing issues
| format: "esm", | ||
| sourcemap: true, | ||
| }, | ||
| ], | ||
| plugins: [nodeResolve(), typescript({ noEmitOnError: true })], | ||
| plugins: [commonjs(), nodeResolve(), typescript({ noEmitOnError: true })], |
There was a problem hiding this comment.
I'm curious if / why this was needed? What commonjs dependencies are bundled into @realm/react?
There was a problem hiding this comment.
Jest is commonjs by default. It takes siginificant amount of manipulation to the jest framework to get it to support es modules.
I have also found that many react native libraries also produce a cjs in their dist for this reason.
There was a problem hiding this comment.
Before this release, if you take a vanilla react native project...add @realm/react and add something using @realm/react in the default tests, it will fail on import
There was a problem hiding this comment.
Sure, but adding this line is not nessesary to emit a CommonJS bundle. It's only needed if you want to include some CommonJS dependency into the bundle.
There was a problem hiding this comment.
Ah ok...then it can most likely be removed. I just assumed I needed it to produce a commonjs output. Thanks for clarifying.
What, How & Why?
This closes #6049
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: