Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to node-addon-api 6 #5703

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Upgrade to node-addon-api 6 #5703

merged 1 commit into from
Apr 5, 2023

Conversation

RedBeard0531
Copy link
Contributor

@cla-bot cla-bot bot added the cla: yes label Apr 5, 2023
@RedBeard0531 RedBeard0531 marked this pull request as ready for review April 5, 2023 13:57
@RedBeard0531
Copy link
Contributor Author

I don't see how I could possibly have broken lint, given that I'm not touching any linted files...

@RedBeard0531
Copy link
Contributor Author

Actually, this also broke some integration tests, but that really shouldn't be possible either... 🤔

I may need some help debugging this.

@kraenhansen
Copy link
Member

I agree, the lint error is on packages/realm/src/schema/types.ts

@kraenhansen
Copy link
Member

kraenhansen commented Apr 5, 2023 •
edited
Loading

I'd say this is okay to merge. Since the windows build broke, the workflow has never gotten to run the integration tests. And I've only ever achieved green tests locally from my kh/enable-all-tests branch.

@kraenhansen
Copy link
Member

The node test results look as green as they've ever been on main.

@RedBeard0531
Copy link
Contributor Author

@kraenhansen I came to the same conclusion. I think this PR is just getting penalized for all the failures that have built up while we weren't running tests 😡

I'll merge as soon as you approve the PR 😃

@RedBeard0531 RedBeard0531 merged commit c989d73 into main Apr 5, 2023
@RedBeard0531 RedBeard0531 deleted the ms/naa-upgrade branch April 5, 2023 14:29
This was referenced Apr 5, 2023
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kraenhansen kraenhansen kraenhansen approved these changes

@takameyer takameyer Awaiting requested review from takameyer

Assignees

@RedBeard0531 RedBeard0531

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix building for "Windows ia32" on main Possible breaking change in node-addon-api 5.1.0
2 participants
@RedBeard0531 @kraenhansen