[bindgen] SDK packaging #5466
[bindgen] SDK packaging #5466
Conversation
| ".": { | ||
| "types": "./dist/bundle.d.ts", | ||
| "node": "./dist/bundle.node.mjs", | ||
| "require": "./dist/bundle.node.js", | ||
| "react-native": "./dist/bundle.react-native.mjs" | ||
| }, |
| @@ -20,6 +20,7 @@ const commandLineArgs = require("command-line-args"); | |||
| const fs = require("fs-extra"); | |||
| const path = require("path"); | |||
| const exec = require("child_process").execFileSync; | |||
| const packageRoot = path.resolve(__dirname, ".."); | |||
There was a problem hiding this comment.
Should we move the build scripts into packages/realm?
There was a problem hiding this comment.
Also this will put the build artifacts in react-native instead of packages/realm/react-native. I think we want to actually delete the root project react-native folder and have everything within packages/realm/react-native, right?
There was a problem hiding this comment.
move the build scripts into
packages/realm?
I was thinking about that. I see pros and cons to it. It probably makes sense to increase cohesion as these will only be used to build the SDK native parts. But then again, the CmakeLists.txt live in the bindgen package right now, which sort of serves the same purpose.
One my thought I had was that I want to refactor and join the build scripts into a single CLI that can invoke cmake when building for Node.js, iOS or Android with one (or more) platform and arch flags.
Also a good idea. It just seems to me that these scripts are only called from within |
@takameyer It was less baked than I remembered 🙂 But it's fixed now. Thanks! |
kraenhansen
force-pushed
the
kh/bindgen/packaging
branch
from
c64eb2c
to
cfc1db6
Compare
* bindgen: Implement getAllSyncSessions (#5492) Ensure that Realm enums are accessible (#5484) Apply suggestions from code review [skip ci] Small corrections [skip ci] Added changelog and final corrections Stub add test to validate that foreach throws on a dictionary (#5467) Using `RealmInsertionModel` on `Results#update` Updated "react-native" dev dep to 0.71.0 Bumped lower bound on our RN peer dependency [bindgen] SDK packaging (#5466) Adding "prebuild" and configuring it (#5447) add synthetic private brand fields to TS wrappers for C++ classes, and fix found bug import bindings directly rather than through internal Stub work
* Moved Android SDK files * Enumerate files to include in package * Adding platform build npm scripts * Updated "exports" object * Removed check for "react-native" existence. * Updated `LIBRARY_OUTPUT_DIRECTORY`
* Moved Android SDK files * Enumerate files to include in package * Adding platform build npm scripts * Updated "exports" object * Removed check for "react-native" existence. * Updated `LIBRARY_OUTPUT_DIRECTORY`
What, How & Why?
This moves the Android source files needed to bootstrap the library into the SDK package to make them available for the dependent apps.
It also updates the package.json with conditional exports as speced here: https://nodejs.org/api/packages.html#conditional-exports
Unfortunately we can't make this a
module: "type"wet, because of a bug in the React Native CLI which breaks reading thereact-native.cli.jsfile (I still have to report this).