Node integration test enviroment #5241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takameyer
approved these changes
Jan 11, 2023
| require("@realm/integration-tests"); | ||
| // Add the integration test suite | ||
| await import("@realm/integration-tests"); | ||
| console.log("integration tests loaded"); |
There was a problem hiding this comment.
I noticed console.logs here and in the updated mocha-client. Do we want to keep those in, or were they just for testing?
There was a problem hiding this comment.
Oh yeah - good catch. They need to go 🙂
| import "./utils/import-app.test"; | ||
| import "./utils/chai-plugin.test"; | ||
| import "./utils/import-app.test.ts"; | ||
| import "./utils/chai-plugin.test.ts"; |
There was a problem hiding this comment.
Is there a way to detect these extensions automatically?
There was a problem hiding this comment.
Yeah, I played around with it. It think it gets confused about the .test part of the extension 😕
There was a problem hiding this comment.
I was getting this issue as well when I was getting the react-native tests to run again, but in a different section. Wasn't really able to resolve it. Very odd.
kraenhansen
added a commit
that referenced
this pull request
Mar 1, 2023
* Adding mocha-reporter and node testenv to NPM WS * Making the Node tests and environment ESM friendly * Upgrading to the latest Mocha Remote * Cleaned up some console.logs
kraenhansen
added a commit
that referenced
this pull request
Mar 3, 2023
* Adding mocha-reporter and node testenv to NPM WS * Making the Node tests and environment ESM friendly * Upgrading to the latest Mocha Remote * Cleaned up some console.logs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This fixes up the Node.js integration test environment, making it ESM friendly in the process.
I had to temporarily skip the Node.js specific "analytics" tests, as they need to be migrated off the non-esm Node.js APIs.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary