Moving platform specific tsconfigs back #5234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takameyer
approved these changes
Jan 9, 2023
kraenhansen
force-pushed
the
kh/bindgen/fix-tsconfigs
branch
from
508d0a3
to
b0124be
Compare
kraenhansen
added a commit
that referenced
this pull request
Mar 1, 2023
* Moving tsconfigs back into platform subdirectories * Cleaning up some debug leftover
kraenhansen
added a commit
that referenced
this pull request
Mar 3, 2023
* Moving tsconfigs back into platform subdirectories * Cleaning up some debug leftover
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This reverts part of 1da0037, moving the platform specific tsconfigs into their respective sub-directories.
As discussed in-person: In general I agree that configs should be top-level, but having them here will help us signal to VSCode which runtime APIs are available for use by the source files in the platform specific directories.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary