Implement App/User Listener #5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used the `subscribe` and `unsubscribe` methods to finish the app listener implementation.
kraenhansen
reviewed
Nov 8, 2022
Comment on lines
73
to
76
| private listeners = new Listeners<AppChangeCallback, AppListenerToken, [binding.App]>({ | ||
| register(callback: () => void, internal: binding.App): AppListenerToken { | ||
| const token = internal.subscribe(callback); | ||
| return { internal, token }; |
There was a problem hiding this comment.
Sorry for the confusion on this when we went through it on the call. It shouldn't be needed to include the App internal into the token, since you can simple read it off the SDK App instance using this.internal.
Suggested change
| private listeners = new Listeners<AppChangeCallback, AppListenerToken, [binding.App]>({ | |
| register(callback: () => void, internal: binding.App): AppListenerToken { | |
| const token = internal.subscribe(callback); | |
| return { internal, token }; | |
| private listeners = new Listeners<AppChangeCallback, binding.AppSubscriptionToken>({ | |
| register(callback: () => void): binding.AppSubscriptionToken { | |
| return this.internal.subscribe(callback); |
There was a problem hiding this comment.
This is fixed now. Needed to convert this into an arrow function so that the App context was binded to this.
kraenhansen
reviewed
Nov 8, 2022
| @@ -68,6 +74,16 @@ export class User< | |||
| /** @internal */ | |||
| public internal: binding.SyncUser; | |||
|
|
|||
| private listeners = new Listeners<UserChangeCallback, UserListenerToken, [binding.SyncUser]>({ | |||
There was a problem hiding this comment.
The same as with the App .. you should be able to get the relevant binding.SyncUser via this.internal
takameyer
force-pushed
the
andrew/applistener
branch
from
846d646
to
014ac0e
Compare
RedBeard0531
pushed a commit
that referenced
this pull request
Nov 15, 2022
* Finish App Listener Used the `subscribe` and `unsubscribe` methods to finish the app listener implementation. * Implement user listeners
RedBeard0531
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Finish App Listener Used the `subscribe` and `unsubscribe` methods to finish the app listener implementation. * Implement user listeners
takameyer
added a commit
that referenced
this pull request
Dec 28, 2022
* Finish App Listener Used the `subscribe` and `unsubscribe` methods to finish the app listener implementation. * Implement user listeners
kraenhansen
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Finish App Listener Used the `subscribe` and `unsubscribe` methods to finish the app listener implementation. * Implement user listeners
kraenhansen
pushed a commit
that referenced
this pull request
Mar 3, 2023
* Finish App Listener Used the `subscribe` and `unsubscribe` methods to finish the app listener implementation. * Implement user listeners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Used the
subscribeandunsubscribemethods to finish the app and user listener implementation.This closes #5062
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: