Match types for User#callFunction implementation across platforms #4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takameyer
changed the title
takameyer
force-pushed
the
andrew/bc-3733
branch
from
4331346 to
27df2ca
Compare
takameyer
force-pushed
the
andrew/bc-3733
branch
from
27df2ca to
b31a3fe
Compare
kneth
approved these changes
Aug 30, 2022
11 tasks
|
@kneth If we removed |
takameyer
force-pushed
the
andrew/bc-3733
branch
from
b31a3fe to
ff01c8c
Compare
takameyer
commented
Aug 31, 2022
takameyer
force-pushed
the
andrew/bc-3733
branch
5 times, most recently
from
051d985 to
8652c05
Compare
|
@kneth Went over this with @kraenhansen. This is a breaking change, as it changes the |
takameyer
force-pushed
the
andrew/bc-3733
branch
2 times, most recently
from
bb86d26 to
88a1fea
Compare
kraenhansen
force-pushed
the
v11
branch
6 times, most recently
from
bd551c6 to
bb8ce55
Compare
takameyer
force-pushed
the
andrew/bc-3733
branch
from
88a1fea to
08b616a
Compare
kraenhansen
reviewed
Sep 13, 2022
takameyer
force-pushed
the
andrew/bc-3733
branch
from
6ca614e to
74f2158
Compare
takameyer
force-pushed
the
andrew/bc-3733
branch
from
74f2158 to
369058c
Compare
The positional argument functions have been removed and now only the object arguments are accepted.
The unifies the call signature of User#callFunction across all documentation
and platforms.
`callFunction` now has the signature:
```javascript
user.callFunction('func', 1, 2, 3);
```
Co-authored-by: Kræn Hansen <[email protected]>
takameyer
force-pushed
the
andrew/bc-3733
branch
from
369058c to
4d9d71d
Compare
kraenhansen
added a commit
that referenced
this pull request
Sep 15, 2022
) * Remove deprecated EmailPasswordAuth functions (#4842) The positional argument functions have been removed and now only the object arguments are accepted. * Match types for `User#callFunction` implementation across platforms The unifies the call signature of User#callFunction across all documentation and platforms. `callFunction` now has the signature: ```javascript user.callFunction('func', 1, 2, 3); ``` * Update lib/user.js Co-authored-by: Kræn Hansen <[email protected]> Co-authored-by: Kræn Hansen <[email protected]>
takameyer
added a commit
that referenced
this pull request
Sep 15, 2022
) * Remove deprecated EmailPasswordAuth functions (#4842) The positional argument functions have been removed and now only the object arguments are accepted. * Match types for `User#callFunction` implementation across platforms The unifies the call signature of User#callFunction across all documentation and platforms. `callFunction` now has the signature: ```javascript user.callFunction('func', 1, 2, 3); ``` * Update lib/user.js Co-authored-by: Kræn Hansen <[email protected]> Co-authored-by: Kræn Hansen <[email protected]>
kraenhansen
added a commit
that referenced
this pull request
Oct 18, 2022
) * Remove deprecated EmailPasswordAuth functions (#4842) The positional argument functions have been removed and now only the object arguments are accepted. * Match types for `User#callFunction` implementation across platforms The unifies the call signature of User#callFunction across all documentation and platforms. `callFunction` now has the signature: ```javascript user.callFunction('func', 1, 2, 3); ``` * Update lib/user.js Co-authored-by: Kræn Hansen <[email protected]> Co-authored-by: Kræn Hansen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The unifies the call signature of
User#callFunctionacross all documentationand platforms.
This closes #3733
☑️ ToDos
Compatibilitylabel is updated or copied from previous entrypackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: