Adding methods and property to manually control write transactions #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristiandupont
suggested changes
Aug 16, 2017
lib/index.d.ts
Outdated
| @@ -452,6 +453,21 @@ declare class Realm { | |||
| * @returns void | |||
| */ | |||
| write(callback: () => void): void; | |||
|
|
|||
| /** | |||
| * @returns void | |||
There was a problem hiding this comment.
We should add the comments from the documentation .js file here as well -- hopefully at some point, this file can be the single source of documentation both for the website and for typescript-aware ide's
There was a problem hiding this comment.
Isn't it better do redo/unite the documentation in a separate PR?
There was a problem hiding this comment.
If this applies to other methods than just this one, then yes. I didn't check for that. :-)
|
@kristiandupont @blagoev I have been through the PR feedback, and I believe it is ready to be merged. |
blagoev
approved these changes
Aug 18, 2017
fealebenpae
reviewed
Aug 21, 2017
This was referenced Aug 21, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Write transactions are currently only done through the
Realm.write()function. Sometimes it is useful to be able to control the write transactions manually. This PR adds a set of methods.See also #715, #815, and #1188.
☑️ ToDos
Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: