Skip to content

Commit

Permalink
Fix potential release issues
Browse files Browse the repository at this point in the history
  • Loading branch information
takameyer committed Feb 5, 2024
1 parent a3300c3 commit 35b62a2
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 7 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/pr-realm-js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
# Due to a limitation in upload-artifact a redundant file is needed to force
# preserving paths (https://github.com/actions/upload-artifact/issues/174)
- name: Upload dist artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: realm-js-jsi
path: |
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
# Due to a limitation in upload-artifact a redundant file is needed to force
# preserving paths (https://github.com/actions/upload-artifact/issues/174)
- name: Upload dist artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: realm-js-ts
path: |
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
${{ runner.os }}-node-
- name: Download TS Bundle
uses: actions/download-artifact@v4
uses: actions/download-artifact@v3
with:
name: realm-js-ts

Expand Down Expand Up @@ -318,13 +318,13 @@ jobs:
echo "wrapper=xvfb-run" >> $GITHUB_ENV
- name: Download JSI
uses: actions/download-artifact@v4
uses: actions/download-artifact@v3
if: ${{ matrix.variant.environment == 'react-native' }}
with:
name: realm-js-jsi

- name: Download TS Bundle
uses: actions/download-artifact@v4
uses: actions/download-artifact@v3
with:
name: realm-js-ts

Expand Down
14 changes: 12 additions & 2 deletions .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,25 @@ jobs:
github_token: ${{ secrets.REALM_CI_PAT }}
name: realm-js-prebuilds

- name: Download bundle artifacts from PR
- name: Download ts bundle artifacts from PR
uses: dawidd6/action-download-artifact@d0f291cf39bd21965ea9c4c6e210fc355c3844ed
with:
workflow: pr-realm-js.yml
commit: ${{ inputs.commit || github.sha }}
path: ${{ github.workspace }}
workflow_conclusion: "" # Ignores workflow conclusion
github_token: ${{ secrets.REALM_CI_PAT }}
name: realm-js-bundles
name: realm-js-ts

- name: Download jsi artifacts from PR
uses: dawidd6/action-download-artifact@d0f291cf39bd21965ea9c4c6e210fc355c3844ed
with:
workflow: pr-realm-js.yml
commit: ${{ inputs.commit || github.sha }}
path: ${{ github.workspace }}
workflow_conclusion: "" # Ignores workflow conclusion
github_token: ${{ secrets.REALM_CI_PAT }}
name: realm-js-jsi

- name: Read version
id: get-version
Expand Down

0 comments on commit 35b62a2

Please sign in to comment.