-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kn/asymmetric sync #1400
kn/asymmetric sync #1400
Conversation
1d36c01
to
abaa322
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some small comments. I think its good. Should we have a final discussion on realm.ingest
vs realm.add
before we merge?
abaa322
to
e4eee93
Compare
Yes, I cannot make up my mind myself. I'm okay with both, but it cannot be as elegant as in realm-dotnet since we cannot overload |
Pull Request Test Coverage Report for Build 6220147351
💛 - Coveralls |
da2a927
to
1022370
Compare
I have created a commit that illustrates how it could be implemented, if we go with |
cf7e1af
to
ee32ce2
Compare
550f53e
to
c214a5b
Compare
For now we will go with |
Support asymmetric objects
Fixes: #917