Remove the use of GlobalKey #8015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer support syncing tables without primary key, so this can be removed. However the management of tombstones did somewhat rely on this, so a more primitive approach where we just make a linear search for potential tombstone that must be revived. This is of course slow, but since this in on the local_only branch, tombstones are only used in some copy operation.
danieltabacaru
approved these changes
Sep 2, 2024
| object_id = allocate_object_id_squeezed(); | ||
| key = object_id.get_local_key(get_sync_file_id()); | ||
| } | ||
| if (auto repl = get_repl()) |
There was a problem hiding this comment.
was this a bug before? (i.e, the instruction was replicated only if the key was null)
There was a problem hiding this comment.
You could say it was a bug, but calling with a specific key was only used in testing.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer support syncing tables without primary key, so this can be removed. However the management of tombstones did somewhat rely on this, so a more primitive approach where we just make a linear search for potential tombstone that must be revived. This is of course slow, but since this in on the local_only branch, tombstones are only used in some copy operation.
What, How & Why?
☑️ ToDos
bindgen/spec.yml, if public C++ API changed