Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/string compression #7803

Draft
wants to merge 23 commits into
base: next-major
Choose a base branch
from
Draft

Feature/string compression #7803

wants to merge 23 commits into from

Commits on Jun 6, 2024

  1. Squashed into single commit relative to next-major

    @finnschiermer
    finnschiermer committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fcb50cd View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Merge branch 'next-major' into fsa/string-interning

    @nicola-cab
    nicola-cab committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9f4d51c View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. No Unique PTRs for string interner and string compressor (#7807) 

    * No unique ptrs for string interner + limit number of interners

* point fix client-reset test

* code review
    @nicola-cab
    nicola-cab authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    22d15d9 View commit details
    Browse the repository at this point in the history

  2. Fix compilation

    @jedelbo
    jedelbo committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8f1d472 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. RCORE-2162: Add compression of strings in Mixed, Lst<String> and Dict… 

    …ionary (#7804)
    @jedelbo
    jedelbo authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    fc31117 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'next-major' into feature/string-compression

    @jedelbo
    jedelbo committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    1d89781 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Merge branch 'next-major' into feature/string-compression

    @nicola-cab
    nicola-cab committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3e8a751 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'next-major' into feature/string-compression

    @jedelbo
    jedelbo committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5112b13 View commit details
    Browse the repository at this point in the history

  2. RCORE-2170 String compression tests (#7812)

    @nicola-cab
    nicola-cab authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    499e630 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Remove enum string feature (#7858)

    @jedelbo
    jedelbo authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ce6f196 View commit details
    Browse the repository at this point in the history

  2. RCORE-2064 String EQ/NEQ optimisations for compressed strings (#7820) 

    * find_first optimization for compressed strings

* core test passing

* compression tests for collection of strings

* code review

* Fixes (#7872)

---------

Co-authored-by: Jørgen Edelbo <[email protected]>
    @nicola-cab @jedelbo
    nicola-cab and jedelbo authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1afc39e View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Merge branch 'next-major' into feature/string-compression

    @nicola-cab
    nicola-cab committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d35c8fc View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. RCORE-2065 use compressed string view for quick comparison if the lea… 

    …f is compressed (#7880)

* use CompressedViewString cmp for compressed leaves

* fix asan

* code review

* fix redudant code
    @nicola-cab
    nicola-cab authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    aec4ca0 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'next-major' into feature/string-compression

    @nicola-cab
    nicola-cab committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    10d4535 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'next-major' into feature/string-compression

    @nicola-cab
    nicola-cab committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    533a0f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. RCORE-2157 Avoid to decompress Strings while sorting them. Instead us… 

    …e fast comparison provided by the interner (#7892)

* initial test

* add logic for fetching stringID to Descriptors (partially working)

* fixes core tests

* ops I cannot use C++20 :-)

* fix test

* fix handling for array mixed when it holds strings

* fix improper use of mixed when it is not string

* Compare only if both string ids are available

* works for strings

* enable mixed and fix bug in cmp function

* code cleanup

* remove alias dup

* fix cmp function + simplify comparison function for sorting

* lint

* more readeable cmp function

* test refactory, still missing cmp over links + mixed of diff type cmp

* tests

* code review

* more tests for utf8

* code review

* code review
    @nicola-cab
    nicola-cab authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9278ebe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next-major' into feature/string-compression

    @nicola-cab
    nicola-cab committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    8f6b79b View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. reduce locking for StringInterner lookup and compare methods

    @finnschiermer
    finnschiermer committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7b6159e View commit details
    Browse the repository at this point in the history

  2. reduced locking in StringInterner::get()

    @finnschiermer
    finnschiermer committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    f9d1021 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. minor fixes and comments

    @finnschiermer
    finnschiermer committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8325c81 View commit details
    Browse the repository at this point in the history

  2. optimize memory ordering a bit

    @finnschiermer
    finnschiermer committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ddc557e View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Merge pull request #7954 from realm/fsa/reduce-string-interner-locking 

    RCORE-2233 Reduce locking for StringInterner lookup and compare methods
    @finnschiermer
    finnschiermer authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    80b95d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Small fix to Table::typed_write 

    When writing the realm to a new file from a write transaction,
the Table may be COW so that the top ref is changed. So don't
use the ref that is present in the group when the operation starts.
    @jedelbo
    jedelbo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9fe448f View commit details
    Browse the repository at this point in the history