Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate object store sync util files into util/ directory #6789

Merged
merged 8 commits into from
Jul 27, 2023

Conversation

michael-wb
Copy link
Contributor

@michael-wb michael-wb commented Jul 14, 2023

What, How & Why?

In preparation of separating the baas server tests to a separate executable, move the util files for the object store sync tests into the util/ directory. The baas server tests will ultimately be moved to the baas/ directory under test/object-store/.

Fixes #6792

☑️ ToDos

  • 📝 Changelog update
  • [ ] 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed.

@michael-wb michael-wb self-assigned this Jul 14, 2023
@cla-bot cla-bot bot added the cla: yes label Jul 14, 2023
Copy link
Contributor

@kiburtse kiburtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks good. Does it make sense to also keep these files under 'test/object-store/util/sync' subdirectory, as with test/sync, src/realm/sync and src/realm/object-store/sync?

@michael-wb
Copy link
Contributor Author

ok, looks good. Does it make sense to also keep these files under 'test/object-store/util/sync' subdirectory, as with test/sync, src/realm/sync and src/realm/object-store/sync?

Sure - moved the sync util files into a sync/ subdirectory

@michael-wb michael-wb merged commit c2a9ab9 into master Jul 27, 2023
2 checks passed
@michael-wb michael-wb deleted the mwb/move-objstore-util-files branch July 27, 2023 15:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate object store sync util files into util/ directory
3 participants