Skip to content

Commit

Permalink
Revert sync protocol version to 12 until client reset with recovery i…
Browse files Browse the repository at this point in the history
…s fixed (#7624)
  • Loading branch information
danieltabacaru authored Apr 26, 2024
1 parent bec09f8 commit 816920b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions src/realm/sync/protocol.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,14 @@ namespace sync {
// Server replaces 'downloadable_bytes' (which was always zero prior this version)
// with an estimated progress value (double from 0.0 to 1.0) for flx sessions
//
// 13 Support for syncing collections (lists and dictionaries) in Mixed columns
//
// XX Changes:
// - TBD
//
constexpr int get_current_protocol_version() noexcept
{
// Also update the current protocol version test in flx_sync.cpp when
// updating this value
return 13;
return 12;
}

constexpr std::string_view get_pbs_websocket_protocol_prefix() noexcept
Expand Down
2 changes: 1 addition & 1 deletion test/object-store/sync/flx_sync.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2583,7 +2583,7 @@ TEST_CASE("flx: writes work without waiting for sync", "[sync][flx][baas]") {
TEST_CASE("flx: verify websocket protocol number and prefixes", "[sync][protocol]") {
// Update the expected value whenever the protocol version is updated - this ensures
// that the current protocol version does not change unexpectedly.
REQUIRE(13 == sync::get_current_protocol_version());
REQUIRE(12 == sync::get_current_protocol_version());
// This was updated in Protocol V8 to use '#' instead of '/' to support the Web SDK
REQUIRE("com.mongodb.realm-sync#" == sync::get_pbs_websocket_protocol_prefix());
REQUIRE("com.mongodb.realm-query-sync#" == sync::get_flx_websocket_protocol_prefix());
Expand Down

0 comments on commit 816920b

Please sign in to comment.