-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @ mark to fix invalid link in Rules.md #2669
Merged
marcelofabri
merged 4 commits into
realm:master
from
pixyzehn:fix-link-for-redundant-@objc-attribute
Mar 13, 2019
Merged
Remove @ mark to fix invalid link in Rules.md #2669
marcelofabri
merged 4 commits into
realm:master
from
pixyzehn:fix-link-for-redundant-@objc-attribute
Mar 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is autogenerated, so we need to fix it in code |
More specifically, this is done in |
@marcelofabri Thank you! Will check the file and try to fix it. |
This reverts commit 1219244.
Just updated the description of this PR. |
Generated by 🚫 Danger |
marcelofabri
approved these changes
Mar 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed punctuation before replacing whitespace with
-
.I took a look at how Github markup works to create named anchors. It said
The resulting HTML is rendered on GitHub.com.
here.So, based on what Github markup used before, I followed the way jch/html-pipeline takes. What do you think? Do you have any idea for that?
ref: