Keep initializers with attributed parameters in `unneeded_synthesized…

…_initializer` rule (#5594)
realm · May 17, 2024 · b42f6ff · b42f6ff
1 parent ebf7c70
commit b42f6ff
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,11 @@
   [SimplyDanny](https://github.com/SimplyDanny)
   [#5592](https://github.com/realm/SwiftLint/issues/5592)
 
+* Keep initializers with attributed parameters in
+  `unneeded_synthesized_initializer` rule.  
+  [SimplyDanny](https://github.com/SimplyDanny)
+  [#5153](https://github.com/realm/SwiftLint/issues/5153)
+
 ## 0.55.1: Universal Washing Powder
 
 #### Breaking

diff --git a/Source/SwiftLintBuiltInRules/Rules/Idiomatic/UnneededSynthesizedInitializerRule.swift b/Source/SwiftLintBuiltInRules/Rules/Idiomatic/UnneededSynthesizedInitializerRule.swift
@@ -132,7 +132,7 @@ private extension StructDeclSyntax {
         }
 
         for (idx, parameter) in initializerParameters.enumerated() {
-            guard parameter.secondName == nil else {
+            guard parameter.secondName == nil, parameter.attributes.isEmpty else {
                 return false
             }
             let property = storedProperties[idx]

diff --git a/...ce/SwiftLintBuiltInRules/Rules/Idiomatic/UnneededSynthesizedInitializerRuleExamples.swift b/...ce/SwiftLintBuiltInRules/Rules/Idiomatic/UnneededSynthesizedInitializerRuleExamples.swift
@@ -198,6 +198,15 @@ enum UnneededSynthesizedInitializerRuleExamples {
                     }
                 }
                 """),
+        Example("""
+                struct Foo {
+                    var bar: Int
+
+                    init(@Clamped bar: Int) {
+                        self.bar = bar
+                    }
+                }
+                """),
         Example("""
                 struct Foo {
                     let bar: Int