Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jiujiteiro/banking restrictions #22

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

jiujiteiro
Copy link
Collaborator

Description

  1. Provides a mechanism for injecting functions that can restrict bank transfers.
  2. Updates InputOutputCoins to take in a single Input. This was originally done with fix: MsgMultiSend validation allows only a single sender cosmos/cosmos-sdk#12610 which was partially reverted with fix: revert proto changes from #12610 cosmos/cosmos-sdk#12670. The revert was needed because a breaking change had been made in the protos, but for some reason reverted more than what was needed. MsgMultiSend allows for only one input, but InputOutputCoins still allowed for multiple. For this change, a single input is needed in InputOutputCoins due to the complexity that would be added if still allowing for multiple inputs.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@jiujiteiro jiujiteiro merged commit 7925cce into release-realio/v0.46.x Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant