Merge pull request #5 from realexpayments-developers/master

Realex Payments Remote Java SDK - v1.0.1
realexpayments · Aug 12, 2015 · e75ec89 · e75ec89
2 parents afda01d + b4f90c0
commit e75ec89
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -9,23 +9,23 @@ Add this dependency to your project's POM:
 <dependency>
   <groupId>com.realexpayments.remote.sdk</groupId>
   <artifactId>rxp-remote-java</artifactId>
-  <version>1.0</version>
+  <version>1.0.1</version>
 </dependency>
 ```
 
 ### Gradle users
 Add this dependency to your project's build file:
 ```
-compile "com.realexpayments.remote.sdk:rxp-remote-java:1.0"
+compile "com.realexpayments.remote.sdk:rxp-remote-java:1.0.1"
 ```
 ##Usage
 ```
 Card card = new Card()
 		.addExpiryDate("0119")
-		.addNumber("420000000000000000")
+		.addNumber("4242424242424242")
 		.addType(CardType.VISA)
 		.addCardHolderName("Joe Smith")
-		.addCvn(123)
+		.addCvn("123")
 		.addCvnPresenceIndicator(PresenceIndicator.CVN_PRESENT);
 
 PaymentRequest request = new PaymentRequest()

diff --git a/pom.xml b/pom.xml
@@ -2,7 +2,7 @@
   	<modelVersion>4.0.0</modelVersion>
   	<groupId>com.realexpayments.remote.sdk</groupId>
   	<artifactId>rxp-remote-java</artifactId>
-  	<version>1.0</version>
+  	<version>1.0.1</version>
   	<name>Realex Payments Remote Java SDK</name>
   	<description>The official Realex Payments Remote Java SDK</description> 
   	<url>http://www.realexpayments.com</url>

diff --git a/src/main/java/com/realexpayments/remote/sdk/domain/Card.java b/src/main/java/com/realexpayments/remote/sdk/domain/Card.java
@@ -19,7 +19,7 @@
  * 		.addNumber("420000000000000000")
  *		.addType(CardType.VISA)
  *		.addCardHolderName("Joe Smith")
- *		.addCvn(123)
+ *		.addCvn("123")
  *		.addCvnPresenceIndicator(PresenceIndicator.CVN_PRESENT); 
  * </pre></code></p>
  * 
@@ -235,7 +235,7 @@ public Card addNumber(String number) {
 	 * @param cvn
 	 * @return Card
 	 */
-	public Card addCvn(Integer cvn) {
+	public Card addCvn(String cvn) {
 		if (null == this.cvn) {
 			this.cvn = new Cvn().addNumber(cvn);
 		} else {

diff --git a/src/main/java/com/realexpayments/remote/sdk/domain/Cvn.java b/src/main/java/com/realexpayments/remote/sdk/domain/Cvn.java
@@ -68,7 +68,7 @@ public String getIndicator() {
 	 * For an AMEX card, it is a four digit number.
 	 */
 	@XmlElement(name = "number")
-	private Integer number;
+	private String number;
 
 	/**
 	 * <p>
@@ -93,9 +93,9 @@ public Cvn() {
 	/**
 	 * Getter for verification number.
 	 * 
-	 * @return Integer
+	 * @return String
 	 */
-	public Integer getNumber() {
+	public String getNumber() {
 		return number;
 	}
 
@@ -104,7 +104,7 @@ public Integer getNumber() {
 	 * 
 	 * @param number
 	 */
-	public void setNumber(Integer number) {
+	public void setNumber(String number) {
 		this.number = number;
 	}
 
@@ -132,7 +132,7 @@ public void setPresenceIndicator(String presenceIndicator) {
 	 * @param number
 	 * @return Cvn
 	 */
-	public Cvn addNumber(Integer number) {
+	public Cvn addNumber(String number) {
 		this.number = number;
 		return this;
 	}

diff --git a/src/main/java/com/realexpayments/remote/sdk/domain/payment/PaymentRequest.java b/src/main/java/com/realexpayments/remote/sdk/domain/payment/PaymentRequest.java
@@ -38,7 +38,7 @@
  * 	.addNumber("420000000000000000")
  * 	.addType(CardType.VISA)
  * 	.addCardHolderName("Joe Smith")
- * 	.addCvn(123)
+ * 	.addCvn("123")
  * 	.addCvnPresenceIndicator(PresenceIndicator.CVN_PRESENT);
  * 
  * PaymentRequest request = new PaymentRequest()
@@ -60,7 +60,7 @@
  * 	.addNumber("420000000000000000")
  * 	.addType(CardType.VISA)
  * 	.addCardHolderName("Joe Smith")
- * 	.addCvn(123)
+ * 	.addCvn("123")
  * 	.addCvnPresenceIndicator(PresenceIndicator.CVN_PRESENT);
  * 
  * PaymentRequest request = new PaymentRequest()
@@ -213,7 +213,7 @@ public String getType() {
 	private String refundHash;
 
 	/**
-	 * TODO - info on this
+	 * Fraud filter flag
 	 */
 	@XmlElement(name = "fraudfilter")
 	private String fraudFilter;

diff --git a/src/main/java/com/realexpayments/remote/sdk/domain/threeDSecure/ThreeDSecureRequest.java b/src/main/java/com/realexpayments/remote/sdk/domain/threeDSecure/ThreeDSecureRequest.java
@@ -38,7 +38,7 @@
  * 	.addNumber("420000000000000000")
  * 	.addType(CardType.VISA)
  * 	.addCardHolderName("Joe Smith")
- * 	.addCvn(123)
+ * 	.addCvn("123")
  * 	.addCvnPresenceIndicator(PresenceIndicator.CVN_PRESENT);
  * 
  * ThreeDSecureRequest request = new ThreeDSecureRequest()

diff --git a/src/test/java/com/realexpayments/remote/sdk/utils/SampleXmlValidationUtils.java b/src/test/java/com/realexpayments/remote/sdk/utils/SampleXmlValidationUtils.java
@@ -45,7 +45,7 @@ public class SampleXmlValidationUtils {
 	public static final String CARD_NUMBER = "420000000000000000";
 	public static final CardType CARD_TYPE = CardType.VISA;
 	public static final String CARD_HOLDER_NAME = "Joe Smith";
-	public static final Integer CARD_CVN_NUMBER = 123;
+	public static final String CARD_CVN_NUMBER = "123";
 	public static final PresenceIndicator CARD_CVN_PRESENCE = PresenceIndicator.CVN_PRESENT;
 	public static final String CARD_EXPIRY_DATE = "0119";
 	public static final Integer CARD_ISSUE_NUMBER = 1;