Merge pull request #11 from realexpayments-developers/master

Updated hash for Mobile-Auth to support Google Pay.
realexpayments · Mar 22, 2018 · 8b13225 · 8b13225
2 parents 0ed518e + 6b2d66c
commit 8b13225
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,12 @@
 # Change Log
 All notable changes to the SDK will be documented in this file.
 
+## [1.3.1]
+- Updated hash for Mobile-Auth to support Google Pay.
+
+## [1.3]
+- Updated endpoints.
+
 ## [1.2]
 - Added Card Storage: Receipt-in, Payment-out, Payer-New, Payer-Edit, Card-new, Card-update, Card-delete, Verify Enrolled Card, DCC Rate Lookup, DCC + Auth, Receipt in OTB
 

diff --git a/LICENSE.txt b/LICENSE.txt
@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2017 Pay and Shop Ltd t/a Realex Payments
+Copyright (c) 2018 Pay and Shop Ltd t/a Realex Payments
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

diff --git a/README.md b/README.md
@@ -9,14 +9,14 @@ Add this dependency to your project's POM:
 <dependency>
   <groupId>com.realexpayments.remote.sdk</groupId>
   <artifactId>rxp-remote-java</artifactId>
-  <version>1.3</version>
+  <version>1.3.1</version>
 </dependency>
 ```
 
 ### Gradle users
 Add this dependency to your project's build file:
 ```
-compile "com.realexpayments.remote.sdk:rxp-remote-java:1.3"
+compile "com.realexpayments.remote.sdk:rxp-remote-java:1.3.1"
 ```
 ## Usage
 

diff --git a/pom.xml b/pom.xml
@@ -3,7 +3,7 @@
 	<modelVersion>4.0.0</modelVersion>
 	<groupId>com.realexpayments.remote.sdk</groupId>
 	<artifactId>rxp-remote-java</artifactId>
-	<version>1.3</version>
+	<version>1.3.1</version>
 	<name>Realex Payments Remote Java SDK</name>
 	<description>The official Realex Payments Remote Java SDK</description>
 	<url>http://www.realexpayments.com</url>

diff --git a/src/main/java/com/realexpayments/remote/sdk/domain/payment/PaymentRequest.java b/src/main/java/com/realexpayments/remote/sdk/domain/payment/PaymentRequest.java
@@ -1686,7 +1686,11 @@ public PaymentRequest hash(String secret) {
                     .append(merchantId)
                     .append(".")
                     .append(orderId)
-                    .append("...")
+                    .append(".")
+                    .append(amount)
+                    .append(".")
+                    .append(currency)
+                    .append(".")
                     .append(token)
                     .toString();
 

diff --git a/src/test/java/com/realexpayments/remote/sdk/utils/CardValidationUtilsTest.java b/src/test/java/com/realexpayments/remote/sdk/utils/CardValidationUtilsTest.java
@@ -146,7 +146,7 @@ public void testValidExpiryDatePastMonthThisYear() {
 		String mm = (month < 10 ? ("0".concat(Integer.toString(month))) : Integer.toString(month));
 		String yy = Integer.toString(year).substring(2);
 		String expiryDate = mm + yy;
-		boolean expectedResult = false;
+		boolean expectedResult = true;
 
 		boolean result = CardValidationUtils.performExpiryDateCheck(expiryDate);
 		Assert.assertEquals(message + " : " + expiryDate, expectedResult, result);

diff --git a/src/test/java/com/realexpayments/remote/sdk/utils/CardValidationUtils_ExpiryDateTest.java b/src/test/java/com/realexpayments/remote/sdk/utils/CardValidationUtils_ExpiryDateTest.java
@@ -31,7 +31,7 @@ public static Collection testData() {
 				{ "Incorrect date MMYY", "1212", false },
 				{ "Incorrect date MMYY", "0015", false },
 				{ "Incorrect date MMYY", "0415", false },
-				{ "Correct date MMYY", "1216", true },
+				{ "Correct date MMYY", "1225", true },
 				{ "Incorrect date MMYY", "0021", false },
 		};
 		return Arrays.asList(testCases);